Re: [PATCH 6/9] objtool: Add elf_create_undef_symbol()

2021-03-18 Thread Peter Zijlstra
On Wed, Mar 17, 2021 at 07:46:14PM -0500, Josh Poimboeuf wrote: > On Wed, Mar 17, 2021 at 03:13:43PM +0100, Peter Zijlstra wrote: > > On Wed, Mar 17, 2021 at 02:52:23PM +0100, Miroslav Benes wrote: > > > > > > + if (!elf_symbol_add(elf, sym, SHN_XINDEX)) { > > > > +

Re: [PATCH 6/9] objtool: Add elf_create_undef_symbol()

2021-03-17 Thread Josh Poimboeuf
On Wed, Mar 17, 2021 at 03:13:43PM +0100, Peter Zijlstra wrote: > On Wed, Mar 17, 2021 at 02:52:23PM +0100, Miroslav Benes wrote: > > > > + if (!elf_symbol_add(elf, sym, SHN_XINDEX)) { > > > + WARN("elf_symbol_add"); > > > + return NULL; > > > + } > > > > SHN_XINDEX means that

Re: [PATCH 6/9] objtool: Add elf_create_undef_symbol()

2021-03-17 Thread Sami Tolvanen
On Wed, Mar 17, 2021 at 7:40 AM Miroslav Benes wrote: > > On Wed, 17 Mar 2021, Peter Zijlstra wrote: > > > On Wed, Mar 17, 2021 at 02:52:23PM +0100, Miroslav Benes wrote: > > > > > > + if (!elf_symbol_add(elf, sym, SHN_XINDEX)) { > > > > + WARN("elf_symbol_add"); > > > > + return

Re: [PATCH 6/9] objtool: Add elf_create_undef_symbol()

2021-03-17 Thread Miroslav Benes
On Wed, 17 Mar 2021, Peter Zijlstra wrote: > On Wed, Mar 17, 2021 at 02:52:23PM +0100, Miroslav Benes wrote: > > > > + if (!elf_symbol_add(elf, sym, SHN_XINDEX)) { > > > + WARN("elf_symbol_add"); > > > + return NULL; > > > + } > > > > SHN_XINDEX means that the extended section

Re: [PATCH 6/9] objtool: Add elf_create_undef_symbol()

2021-03-17 Thread Peter Zijlstra
On Wed, Mar 17, 2021 at 02:52:23PM +0100, Miroslav Benes wrote: > > + if (!elf_symbol_add(elf, sym, SHN_XINDEX)) { > > + WARN("elf_symbol_add"); > > + return NULL; > > + } > > SHN_XINDEX means that the extended section index is used. Above you seem > to use it in the

Re: [PATCH 6/9] objtool: Add elf_create_undef_symbol()

2021-03-17 Thread Miroslav Benes
[ also correcting my e-mail address ] On Fri, 12 Mar 2021, Peter Zijlstra wrote: Just a remark regarding SHN_XINDEX... > +static bool elf_symbol_add(struct elf *elf, struct symbol *sym, Elf32_Word > shndx) > +{ > + struct list_head *entry; > + struct rb_node *pnode; > + > +

[PATCH 6/9] objtool: Add elf_create_undef_symbol()

2021-03-12 Thread Peter Zijlstra
Allow objtool to create undefined symbols; this allows creating relocations to symbols not currently in the symbol table. Signed-off-by: Peter Zijlstra (Intel) --- tools/objtool/elf.c | 180 +++- tools/objtool/include/objtool/elf.h |1 2