On Mon, Mar 11, 2013 at 01:28:18PM -0700, Tejun Heo wrote:
> Ah, right, in preloaded section, the allocation is expected to fail
> before falling back to the preload buffer and I forgot to add
> __GFP_NOWARN to the first try. Something like the following should
> make it go away. Can you please
On Mon, Mar 11, 2013 at 01:28:18PM -0700, Tejun Heo wrote:
Ah, right, in preloaded section, the allocation is expected to fail
before falling back to the preload buffer and I forgot to add
__GFP_NOWARN to the first try. Something like the following should
make it go away. Can you please test
Hello, David.
On Mon, Mar 11, 2013 at 03:29:55PM -0400, David Teigland wrote:
> On Wed, Feb 06, 2013 at 11:40:39AM -0800, Tejun Heo wrote:
> > static int create_lkb(struct dlm_ls *ls, struct dlm_lkb **lkb_ret)
> > {
> > struct dlm_lkb *lkb;
> > - int rv, id;
> > + int rv;
> >
> >
On Wed, Feb 06, 2013 at 11:40:39AM -0800, Tejun Heo wrote:
> static int create_lkb(struct dlm_ls *ls, struct dlm_lkb **lkb_ret)
> {
> struct dlm_lkb *lkb;
> - int rv, id;
> + int rv;
>
> lkb = dlm_allocate_lkb(ls);
> if (!lkb)
> @@ -1199,19 +1199,13 @@ static int
On Wed, Feb 06, 2013 at 11:40:39AM -0800, Tejun Heo wrote:
static int create_lkb(struct dlm_ls *ls, struct dlm_lkb **lkb_ret)
{
struct dlm_lkb *lkb;
- int rv, id;
+ int rv;
lkb = dlm_allocate_lkb(ls);
if (!lkb)
@@ -1199,19 +1199,13 @@ static int
Hello, David.
On Mon, Mar 11, 2013 at 03:29:55PM -0400, David Teigland wrote:
On Wed, Feb 06, 2013 at 11:40:39AM -0800, Tejun Heo wrote:
static int create_lkb(struct dlm_ls *ls, struct dlm_lkb **lkb_ret)
{
struct dlm_lkb *lkb;
- int rv, id;
+ int rv;
lkb =
Convert to the much saner new idr interface. Error return values from
recover_idr_add() mix -1 and -errno. The conversion doesn't change
that but it looks iffy.
Only compile tested.
Signed-off-by: Tejun Heo
---
fs/dlm/lock.c| 18 ++
fs/dlm/recover.c | 27
Convert to the much saner new idr interface. Error return values from
recover_idr_add() mix -1 and -errno. The conversion doesn't change
that but it looks iffy.
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
---
fs/dlm/lock.c| 18 ++
fs/dlm/recover.c | 27
8 matches
Mail list logo