Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.

2007-12-30 Thread Ingo Molnar
* Julia Lawall <[EMAIL PROTECTED]> wrote: > > hm, #include file order in a .c file should normally not matter - > > why are they in the wrong place? > > Because they are under #ifdefs, but the code that uses the time > functions is not under the same #ifdef. ah, ok - you are right. I fixed th

Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.

2007-12-30 Thread Julia Lawall
On Sun, 30 Dec 2007, Ingo Molnar wrote: > > * Julia Lawall <[EMAIL PROTECTED]> wrote: > > > > your x86 patches (#7, #8 and #9) do not include any *_eq() > > > comparisons and they all seem to be correct. So picked those three > > > up into x86.git - let me know if there's any breakage in them

Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.

2007-12-30 Thread Ingo Molnar
* Julia Lawall <[EMAIL PROTECTED]> wrote: > > your x86 patches (#7, #8 and #9) do not include any *_eq() > > comparisons and they all seem to be correct. So picked those three > > up into x86.git - let me know if there's any breakage in them that i > > missed. > > Only #7 is ok. The other tw

Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.

2007-12-30 Thread Julia Lawall
On Sun, 30 Dec 2007, Ingo Molnar wrote: > > * Julia Lawall <[EMAIL PROTECTED]> wrote: > > > On Mon, 24 Dec 2007, Andi Kleen wrote: > > > > > On Mon, Dec 24, 2007 at 03:23:19PM +0100, Julia Lawall wrote: > > > > From: Julia Lawall <[EMAIL PROTECTED]> > > > > > > > > The functions time_before, t

Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.

2007-12-30 Thread Ingo Molnar
* Julia Lawall <[EMAIL PROTECTED]> wrote: > On Mon, 24 Dec 2007, Andi Kleen wrote: > > > On Mon, Dec 24, 2007 at 03:23:19PM +0100, Julia Lawall wrote: > > > From: Julia Lawall <[EMAIL PROTECTED]> > > > > > > The functions time_before, time_before_eq, time_after, and time_after_eq > > > are more

Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.

2007-12-24 Thread Julia Lawall
On Mon, 24 Dec 2007, Andi Kleen wrote: > On Mon, Dec 24, 2007 at 03:23:19PM +0100, Julia Lawall wrote: > > From: Julia Lawall <[EMAIL PROTECTED]> > > > > The functions time_before, time_before_eq, time_after, and time_after_eq > > are more robust for comparing jiffies against other values. > > T

Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.

2007-12-24 Thread Andi Kleen
On Mon, Dec 24, 2007 at 03:23:19PM +0100, Julia Lawall wrote: > From: Julia Lawall <[EMAIL PROTECTED]> > > The functions time_before, time_before_eq, time_after, and time_after_eq > are more robust for comparing jiffies against other values. The old code was actually correct I think, but the chan

[PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc.

2007-12-24 Thread Julia Lawall
From: Julia Lawall <[EMAIL PROTECTED]> The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. A simplified version of the semantic patch making this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @ ch