Re: [PATCH 7/7] arm64: dts: qcom: sdm845: enable dma for spi

2021-01-11 Thread Vinod Koul
On 11-01-21, 21:45, Konrad Dybcio wrote: > > > If it is working without GPI enabled, it would work.. GPI for QUP is > > something that requires firmware and would have to be enabled by > > firmware > > > I think with the new code of yours: > > > mas->tx = dma_request_slave_channel(mas->dev, "t

Re: [PATCH 7/7] arm64: dts: qcom: sdm845: enable dma for spi

2021-01-11 Thread Konrad Dybcio
> If it is working without GPI enabled, it would work.. GPI for QUP is > something that requires firmware and would have to be enabled by > firmware I think with the new code of yours: mas->tx = dma_request_slave_channel(mas->dev, "tx"); + if (IS_ERR_OR_NULL(mas->tx)) { + dev_err(mas->dev, "F

Re: [PATCH 7/7] arm64: dts: qcom: sdm845: enable dma for spi

2021-01-11 Thread Vinod Koul
On 11-01-21, 08:47, Doug Anderson wrote: > Hi, > > On Mon, Jan 11, 2021 at 7:18 AM Vinod Koul wrote: > > > > @@ -2622,6 +2626,13 @@ pinmux { > >"gpio2", "gpio3"; > > function = "qup0"; > >

Re: [PATCH 7/7] arm64: dts: qcom: sdm845: enable dma for spi

2021-01-11 Thread Vinod Koul
Hi Konrad, On 11-01-21, 17:04, Konrad Dybcio wrote: > Hi, > > looks like sdm845-cheza also uses the spi0 bus, which as far as I > understand is going to break with the GPI DMA disabled. Perhaps it > should also be enabled over there? If it is working without GPI enabled, it would work.. GPI for

Re: [PATCH 7/7] arm64: dts: qcom: sdm845: enable dma for spi

2021-01-11 Thread Doug Anderson
Hi, On Mon, Jan 11, 2021 at 7:18 AM Vinod Koul wrote: > > @@ -2622,6 +2626,13 @@ pinmux { >"gpio2", "gpio3"; > function = "qup0"; > }; > + > + conf

Re: [PATCH 7/7] arm64: dts: qcom: sdm845: enable dma for spi

2021-01-11 Thread Konrad Dybcio
Hi, looks like sdm845-cheza also uses the spi0 bus, which as far as I understand is going to break with the GPI DMA disabled. Perhaps it should also be enabled over there? Actually, is there a point in disabling DMA for BLSPs/QUPs in the SoC DTSI? I don't think any platform/vendor firmware dis

[PATCH 7/7] arm64: dts: qcom: sdm845: enable dma for spi

2021-01-11 Thread Vinod Koul
Add dmas property for spi@88 and pinconf setting so that we can use dma for this spi device. Also, add iommu properties for qup and spi. Signed-off-by: Vinod Koul --- arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 arch/arm64/boot/dts/qcom/sdm845.dtsi | 11 +++ 2 files ch