RE: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

2015-08-26 Thread 河合英宏 / KAWAI，HIDEHIRO
> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard > > On 08/24/2015 10:53 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: > >> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard > >> > >> On 08/23/2015 08:52 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: > From: Corey

Re: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

2015-08-26 Thread Corey Minyard
On 08/24/2015 10:53 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: >> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard >> >> On 08/23/2015 08:52 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard On 08/17/2015 09:

RE: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

2015-08-24 Thread 河合英宏 / KAWAI，HIDEHIRO
> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard > > On 08/23/2015 08:52 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: > >> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard > >> > >> On 08/17/2015 09:54 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: > From: Corey

Re: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

2015-08-24 Thread Corey Minyard
On 08/23/2015 08:52 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: >> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard >> >> On 08/17/2015 09:54 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard This patch will b

RE: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

2015-08-23 Thread 河合英宏 / KAWAI，HIDEHIRO
> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard > > On 08/17/2015 09:54 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: > >> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard > >> > >> This patch will break ATN handling on the interfaces. So we can't do th

Re: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

2015-08-23 Thread Corey Minyard
On 08/17/2015 09:54 PM, 河合英宏 / KAWAI，HIDEHIRO wrote: >> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard >> >> This patch will break ATN handling on the interfaces. So we can't do this. > I understand. So how about doing like this: > > /* All states wait for ibf,

RE: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

2015-08-17 Thread 河合英宏 / KAWAI，HIDEHIRO
> From: Corey Minyard [mailto:tcminy...@gmail.com] On Behalf Of Corey Minyard > > This patch will break ATN handling on the interfaces. So we can't do this. I understand. So how about doing like this: /* All states wait for ibf, so just do it here. */ - if (!check_ibf(kcs, status

Re: [PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

2015-08-13 Thread Corey Minyard
This patch will break ATN handling on the interfaces. So we can't do this. It's going to be extremely hard to recover if the BMC is not working correctly when a panic happens. I'm not sure what can be done, but if you can fix it another way it would be good. -corey On 07/27/2015 12:55 AM, Hide

[PATCH 7/7] ipmi/kcs: Don't run the KCS state machine when it is KCS_IDLE

2015-07-26 Thread Hidehiro Kawai
If a BMC is unresponsive for some reason, it ends up completing the requested message as an error, then kcs_event() is called once to advance the state machine. However, since the BMC is unresponsive now, the status of the KCS interface may not be idle. As the result, the state machine can contin