RE: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread Xu, Even
<srinivas.pandruv...@linux.intel.com> Cc: Xu, Even <even...@intel.com>; ji...@kernel.org; benjamin.tissoi...@redhat.com; a...@arndb.de; Shevchenko, Andriy <andriy.shevche...@intel.com>; linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] misc: intel-ish

RE: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread Xu, Even
, Even ; ji...@kernel.org; benjamin.tissoi...@redhat.com; a...@arndb.de; Shevchenko, Andriy ; linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver On Wed, Jan 04, 2017 at 10:41:26AM -0800, Srinivas Pandruvada wrote

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread Greg KH
On Wed, Jan 04, 2017 at 10:41:26AM -0800, Srinivas Pandruvada wrote: > On Wed, 2017-01-04 at 18:18 +0100, Greg KH wrote: > > On Wed, Jan 04, 2017 at 09:11:34AM -0800, Srinivas Pandruvada wrote: > > > > > > On Wed, 2017-01-04 at 14:03 +0100, Greg KH wrote: > > > > > > > > On Fri, Dec 23, 2016 at

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread Greg KH
On Wed, Jan 04, 2017 at 10:41:26AM -0800, Srinivas Pandruvada wrote: > On Wed, 2017-01-04 at 18:18 +0100, Greg KH wrote: > > On Wed, Jan 04, 2017 at 09:11:34AM -0800, Srinivas Pandruvada wrote: > > > > > > On Wed, 2017-01-04 at 14:03 +0100, Greg KH wrote: > > > > > > > > On Fri, Dec 23, 2016 at

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread Srinivas Pandruvada
On Wed, 2017-01-04 at 18:18 +0100, Greg KH wrote: > On Wed, Jan 04, 2017 at 09:11:34AM -0800, Srinivas Pandruvada wrote: > > > > On Wed, 2017-01-04 at 14:03 +0100, Greg KH wrote: > > > > > > On Fri, Dec 23, 2016 at 09:22:29AM +0800, Even Xu wrote > > > > [...] > debug should not require a char

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread Srinivas Pandruvada
On Wed, 2017-01-04 at 18:18 +0100, Greg KH wrote: > On Wed, Jan 04, 2017 at 09:11:34AM -0800, Srinivas Pandruvada wrote: > > > > On Wed, 2017-01-04 at 14:03 +0100, Greg KH wrote: > > > > > > On Fri, Dec 23, 2016 at 09:22:29AM +0800, Even Xu wrote > > > > [...] > debug should not require a char

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread Greg KH
On Wed, Jan 04, 2017 at 09:11:34AM -0800, Srinivas Pandruvada wrote: > On Wed, 2017-01-04 at 14:03 +0100, Greg KH wrote: > > On Fri, Dec 23, 2016 at 09:22:29AM +0800, Even Xu wrote: > > > > > > Intel ISHFW supports many different clients, in > > > hid/intel-ish-hid/ishtp bus driver, it creates

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread Greg KH
On Wed, Jan 04, 2017 at 09:11:34AM -0800, Srinivas Pandruvada wrote: > On Wed, 2017-01-04 at 14:03 +0100, Greg KH wrote: > > On Fri, Dec 23, 2016 at 09:22:29AM +0800, Even Xu wrote: > > > > > > Intel ISHFW supports many different clients, in > > > hid/intel-ish-hid/ishtp bus driver, it creates

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread Srinivas Pandruvada
On Wed, 2017-01-04 at 14:03 +0100, Greg KH wrote: > On Fri, Dec 23, 2016 at 09:22:29AM +0800, Even Xu wrote: > > > > Intel ISHFW supports many different clients, in > > hid/intel-ish-hid/ishtp bus driver, it creates following client > > devices: > > HID client: > > interface of sensor

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread Srinivas Pandruvada
On Wed, 2017-01-04 at 14:03 +0100, Greg KH wrote: > On Fri, Dec 23, 2016 at 09:22:29AM +0800, Even Xu wrote: > > > > Intel ISHFW supports many different clients, in > > hid/intel-ish-hid/ishtp bus driver, it creates following client > > devices: > > HID client: > > interface of sensor

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread Greg KH
On Fri, Dec 23, 2016 at 09:22:29AM +0800, Even Xu wrote: > +static int ishtp_cl_open(struct inode *inode, struct file *file) > +{ > + struct miscdevice *misc = file->private_data; > + struct ishtp_cl *cl; > + struct ishtp_device *dev; > + struct ishtp_cl_miscdev *ishtp_cl_misc; > +

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread Greg KH
On Fri, Dec 23, 2016 at 09:22:29AM +0800, Even Xu wrote: > +static int ishtp_cl_open(struct inode *inode, struct file *file) > +{ > + struct miscdevice *misc = file->private_data; > + struct ishtp_cl *cl; > + struct ishtp_device *dev; > + struct ishtp_cl_miscdev *ishtp_cl_misc; > +

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread Greg KH
On Fri, Dec 23, 2016 at 09:22:29AM +0800, Even Xu wrote: > +/** > + * ishtp_cl_probe() - ISHTP client driver probe > + * @cl_device: ISHTP client device instance > + * > + * This function gets called on device create on ISHTP bus > + * > + * Return: 0 on success, non zero on error >

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread Greg KH
On Fri, Dec 23, 2016 at 09:22:29AM +0800, Even Xu wrote: > +/** > + * ishtp_cl_probe() - ISHTP client driver probe > + * @cl_device: ISHTP client device instance > + * > + * This function gets called on device create on ISHTP bus > + * > + * Return: 0 on success, non zero on error >

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread Greg KH
On Fri, Dec 23, 2016 at 09:22:29AM +0800, Even Xu wrote: > Intel ISHFW supports many different clients, in > hid/intel-ish-hid/ishtp bus driver, it creates following client devices: > HID client: > interface of sensor configure and sensor event report. > SMHI client: > interface of

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread Greg KH
On Fri, Dec 23, 2016 at 09:22:29AM +0800, Even Xu wrote: > Intel ISHFW supports many different clients, in > hid/intel-ish-hid/ishtp bus driver, it creates following client devices: > HID client: > interface of sensor configure and sensor event report. > SMHI client: > interface of

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread gre...@linuxfoundation.org
On Wed, Jan 04, 2017 at 10:36:18AM +0100, Jiri Kosina wrote: > On Wed, 4 Jan 2017, Xu, Even wrote: > > > > [ ... snip ... ] > > > > > > > > +static ssize_t ishtp_cl_write(struct file *file, const char __user > > > > *ubuf, > > > > + size_t length, loff_t *offset) > > > > +{ > > > > +

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread gre...@linuxfoundation.org
On Wed, Jan 04, 2017 at 10:36:18AM +0100, Jiri Kosina wrote: > On Wed, 4 Jan 2017, Xu, Even wrote: > > > > [ ... snip ... ] > > > > > > > > +static ssize_t ishtp_cl_write(struct file *file, const char __user > > > > *ubuf, > > > > + size_t length, loff_t *offset) > > > > +{ > > > > +

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread Jiri Kosina
On Wed, 4 Jan 2017, Xu, Even wrote: > > [ ... snip ... ] > > > > > > +static ssize_t ishtp_cl_write(struct file *file, const char __user > > > *ubuf, > > > + size_t length, loff_t *offset) > > > +{ > > > + struct ishtp_cl_miscdev *ishtp_cl_misc = file- > > > >private_data; > > > + struct

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-04 Thread Jiri Kosina
On Wed, 4 Jan 2017, Xu, Even wrote: > > [ ... snip ... ] > > > > > > +static ssize_t ishtp_cl_write(struct file *file, const char __user > > > *ubuf, > > > + size_t length, loff_t *offset) > > > +{ > > > + struct ishtp_cl_miscdev *ishtp_cl_misc = file- > > > >private_data; > > > + struct

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-03 Thread Xu, Even
On 二, 2017-01-03 at 10:54 +0100, Jiri Kosina wrote: > On Fri, 23 Dec 2016, Even Xu wrote: > > [ ... snip ... ] > > > > +static ssize_t ishtp_cl_write(struct file *file, const char __user > > *ubuf, > > + size_t length, loff_t *offset) > > +{ > > + struct ishtp_cl_miscdev *ishtp_cl_misc =

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-03 Thread Xu, Even
On 二, 2017-01-03 at 10:54 +0100, Jiri Kosina wrote: > On Fri, 23 Dec 2016, Even Xu wrote: > > [ ... snip ... ] > > > > +static ssize_t ishtp_cl_write(struct file *file, const char __user > > *ubuf, > > + size_t length, loff_t *offset) > > +{ > > + struct ishtp_cl_miscdev *ishtp_cl_misc =

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-03 Thread Jiri Kosina
On Fri, 23 Dec 2016, Even Xu wrote: [ ... snip ... ] > +static ssize_t ishtp_cl_write(struct file *file, const char __user *ubuf, > + size_t length, loff_t *offset) > +{ > + struct ishtp_cl_miscdev *ishtp_cl_misc = file->private_data; > + struct ishtp_cl *cl; > + void *write_buf;

Re: [PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2017-01-03 Thread Jiri Kosina
On Fri, 23 Dec 2016, Even Xu wrote: [ ... snip ... ] > +static ssize_t ishtp_cl_write(struct file *file, const char __user *ubuf, > + size_t length, loff_t *offset) > +{ > + struct ishtp_cl_miscdev *ishtp_cl_misc = file->private_data; > + struct ishtp_cl *cl; > + void *write_buf;

[PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2016-12-22 Thread Even Xu
Intel ISHFW supports many different clients, in hid/intel-ish-hid/ishtp bus driver, it creates following client devices: HID client: interface of sensor configure and sensor event report. SMHI client: interface of sensor calibration, ISHFW debug, ISHFW performance analysis

[PATCH 7/7] misc: intel-ish-client: add intel ishtp clients driver

2016-12-22 Thread Even Xu
Intel ISHFW supports many different clients, in hid/intel-ish-hid/ishtp bus driver, it creates following client devices: HID client: interface of sensor configure and sensor event report. SMHI client: interface of sensor calibration, ISHFW debug, ISHFW performance analysis