Re: [PATCH 7/7] nvme: provide UUID value to userspace

2017-05-30 Thread Johannes Thumshirn
On 05/30/2017 11:30 AM, Christoph Hellwig wrote: > Eww. This looks pretty sketchy and at least needs a good comment in > the source. Maybe even a printk_ratelimited warning. Comment sure, but do we really need a warning? -- Johannes Thumshirn Storage

Re: [PATCH 7/7] nvme: provide UUID value to userspace

2017-05-30 Thread Johannes Thumshirn
On 05/30/2017 11:30 AM, Christoph Hellwig wrote: > Eww. This looks pretty sketchy and at least needs a good comment in > the source. Maybe even a printk_ratelimited warning. Comment sure, but do we really need a warning? -- Johannes Thumshirn Storage

Re: [PATCH 7/7] nvme: provide UUID value to userspace

2017-05-30 Thread Christoph Hellwig
On Tue, May 30, 2017 at 10:08:22AM +0200, Johannes Thumshirn wrote: > Now that we have a way for getting the UUID from a target, provide it > to userspace as well. > > Unfortunately there is already a sysfs attribute called UUID which is > a misnomer as it holds the NGUID value. So instead of

Re: [PATCH 7/7] nvme: provide UUID value to userspace

2017-05-30 Thread Christoph Hellwig
On Tue, May 30, 2017 at 10:08:22AM +0200, Johannes Thumshirn wrote: > Now that we have a way for getting the UUID from a target, provide it > to userspace as well. > > Unfortunately there is already a sysfs attribute called UUID which is > a misnomer as it holds the NGUID value. So instead of

Re: [PATCH 7/7] nvme: provide UUID value to userspace

2017-05-30 Thread Hannes Reinecke
On 05/30/2017 10:08 AM, Johannes Thumshirn wrote: > Now that we have a way for getting the UUID from a target, provide it > to userspace as well. > > Unfortunately there is already a sysfs attribute called UUID which is > a misnomer as it holds the NGUID value. So instead of creating yet >

Re: [PATCH 7/7] nvme: provide UUID value to userspace

2017-05-30 Thread Hannes Reinecke
On 05/30/2017 10:08 AM, Johannes Thumshirn wrote: > Now that we have a way for getting the UUID from a target, provide it > to userspace as well. > > Unfortunately there is already a sysfs attribute called UUID which is > a misnomer as it holds the NGUID value. So instead of creating yet >

[PATCH 7/7] nvme: provide UUID value to userspace

2017-05-30 Thread Johannes Thumshirn
Now that we have a way for getting the UUID from a target, provide it to userspace as well. Unfortunately there is already a sysfs attribute called UUID which is a misnomer as it holds the NGUID value. So instead of creating yet another wrong name, create a new 'nguid' sysfs attribute for the

[PATCH 7/7] nvme: provide UUID value to userspace

2017-05-30 Thread Johannes Thumshirn
Now that we have a way for getting the UUID from a target, provide it to userspace as well. Unfortunately there is already a sysfs attribute called UUID which is a misnomer as it holds the NGUID value. So instead of creating yet another wrong name, create a new 'nguid' sysfs attribute for the