Re: [PATCH 7/7] perf tools: Refine perf_mmap__read_init

2018-03-06 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 06, 2018 at 08:29:03AM -0500, Liang, Kan escreveu: > > > On 3/5/2018 5:25 PM, Jiri Olsa wrote: > > On Mon, Mar 05, 2018 at 02:10:59PM -0500, kan.li...@linux.intel.com wrote: > > > > SNIP > > > > > diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c > > > index

Re: [PATCH 7/7] perf tools: Refine perf_mmap__read_init

2018-03-06 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 06, 2018 at 08:29:03AM -0500, Liang, Kan escreveu: > > > On 3/5/2018 5:25 PM, Jiri Olsa wrote: > > On Mon, Mar 05, 2018 at 02:10:59PM -0500, kan.li...@linux.intel.com wrote: > > > > SNIP > > > > > diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c > > > index

Re: [PATCH 7/7] perf tools: Refine perf_mmap__read_init

2018-03-06 Thread Liang, Kan
On 3/5/2018 5:25 PM, Jiri Olsa wrote: On Mon, Mar 05, 2018 at 02:10:59PM -0500, kan.li...@linux.intel.com wrote: SNIP diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c index e3921ed..403c5e6 100644 --- a/tools/perf/util/mmap.c +++ b/tools/perf/util/mmap.c @@ -235,16 +235,13 @@

Re: [PATCH 7/7] perf tools: Refine perf_mmap__read_init

2018-03-06 Thread Liang, Kan
On 3/5/2018 5:25 PM, Jiri Olsa wrote: On Mon, Mar 05, 2018 at 02:10:59PM -0500, kan.li...@linux.intel.com wrote: SNIP diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c index e3921ed..403c5e6 100644 --- a/tools/perf/util/mmap.c +++ b/tools/perf/util/mmap.c @@ -235,16 +235,13 @@

Re: [PATCH 7/7] perf tools: Refine perf_mmap__read_init

2018-03-05 Thread Jiri Olsa
On Mon, Mar 05, 2018 at 02:10:59PM -0500, kan.li...@linux.intel.com wrote: SNIP > diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c > index e3921ed..403c5e6 100644 > --- a/tools/perf/util/mmap.c > +++ b/tools/perf/util/mmap.c > @@ -235,16 +235,13 @@ static int

Re: [PATCH 7/7] perf tools: Refine perf_mmap__read_init

2018-03-05 Thread Jiri Olsa
On Mon, Mar 05, 2018 at 02:10:59PM -0500, kan.li...@linux.intel.com wrote: SNIP > diff --git a/tools/perf/util/mmap.c b/tools/perf/util/mmap.c > index e3921ed..403c5e6 100644 > --- a/tools/perf/util/mmap.c > +++ b/tools/perf/util/mmap.c > @@ -235,16 +235,13 @@ static int

[PATCH 7/7] perf tools: Refine perf_mmap__read_init

2018-03-05 Thread kan . liang
From: Kan Liang It doesn't need to pass the 'start' and 'end' boilerplate to perf_mmap__read_init(). The data will be stored in the struct perf_mmap. Discard the parameters. Signed-off-by: Kan Liang ---

[PATCH 7/7] perf tools: Refine perf_mmap__read_init

2018-03-05 Thread kan . liang
From: Kan Liang It doesn't need to pass the 'start' and 'end' boilerplate to perf_mmap__read_init(). The data will be stored in the struct perf_mmap. Discard the parameters. Signed-off-by: Kan Liang --- tools/perf/arch/x86/tests/perf-time-to-tsc.c | 3 +-- tools/perf/builtin-kvm.c