Re: [PATCH 7/7] x86/microcode: Recheck IBRS features on microcode reload

2018-01-05 Thread Andrea Arcangeli
Hello everyone, On Fri, Jan 05, 2018 at 02:32:17PM +0100, Greg Kroah-Hartman wrote: > On Thu, Jan 04, 2018 at 07:50:33PM +0100, Borislav Petkov wrote: > > On Thu, Jan 04, 2018 at 07:34:30PM +0100, Andrea Arcangeli wrote: > > > void spec_ctrl_rescan_cpuid(void) > > > { > > > int cpu; > > > > > >

Re: [PATCH 7/7] x86/microcode: Recheck IBRS features on microcode reload

2018-01-05 Thread Greg KH
On Fri, Jan 05, 2018 at 02:37:17PM +0100, Borislav Petkov wrote: > On Fri, Jan 05, 2018 at 02:32:17PM +0100, Greg KH wrote: > > Does it really matter? Rescanning everything can't hurt here, and it > > shouldn't be noticable in any boot time chart. I feel like arguing > > about tiny stuff like thi

Re: [PATCH 7/7] x86/microcode: Recheck IBRS features on microcode reload

2018-01-05 Thread Borislav Petkov
On Fri, Jan 05, 2018 at 02:32:17PM +0100, Greg KH wrote: > Does it really matter? Rescanning everything can't hurt here, and it > shouldn't be noticable in any boot time chart. I feel like arguing > about tiny stuff like this takes away from the obvious other problems > this whole patch series ha

Re: [PATCH 7/7] x86/microcode: Recheck IBRS features on microcode reload

2018-01-05 Thread Greg KH
On Thu, Jan 04, 2018 at 07:50:33PM +0100, Borislav Petkov wrote: > On Thu, Jan 04, 2018 at 07:34:30PM +0100, Andrea Arcangeli wrote: > > void spec_ctrl_rescan_cpuid(void) > > { > > int cpu; > > > > if (use_ibp_disable) > > return; > > mutex_lock(&spec_ctrl_mutex); > > i

Re: [PATCH 7/7] x86/microcode: Recheck IBRS features on microcode reload

2018-01-04 Thread Tim Chen
On 01/04/2018 10:50 AM, Borislav Petkov wrote: > On Thu, Jan 04, 2018 at 07:34:30PM +0100, Andrea Arcangeli wrote: >> void spec_ctrl_rescan_cpuid(void) >> { >> int cpu; >> >> if (use_ibp_disable) >> return; >> mutex_lock(&spec_ctrl_mutex); >> if (boot_cpu_data.x86_v

Re: [PATCH 7/7] x86/microcode: Recheck IBRS features on microcode reload

2018-01-04 Thread Borislav Petkov
On Thu, Jan 04, 2018 at 07:34:30PM +0100, Andrea Arcangeli wrote: > void spec_ctrl_rescan_cpuid(void) > { > int cpu; > > if (use_ibp_disable) > return; > mutex_lock(&spec_ctrl_mutex); > if (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL || > boot_cpu_d

Re: [PATCH 7/7] x86/microcode: Recheck IBRS features on microcode reload

2018-01-04 Thread Andrea Arcangeli
On Thu, Jan 04, 2018 at 07:28:58PM +0100, Borislav Petkov wrote: > On Thu, Jan 04, 2018 at 09:56:48AM -0800, Tim Chen wrote: > > On new microcode write, check whether IBRS > > is present by rescanning scattered CPU features. > > > > Signed-off-by: Tim Chen > > --- > > arch/x86/kernel/cpu/microco

Re: [PATCH 7/7] x86/microcode: Recheck IBRS features on microcode reload

2018-01-04 Thread Borislav Petkov
On Thu, Jan 04, 2018 at 09:56:48AM -0800, Tim Chen wrote: > On new microcode write, check whether IBRS > is present by rescanning scattered CPU features. > > Signed-off-by: Tim Chen > --- > arch/x86/kernel/cpu/microcode/core.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/

[PATCH 7/7] x86/microcode: Recheck IBRS features on microcode reload

2018-01-04 Thread Tim Chen
On new microcode write, check whether IBRS is present by rescanning scattered CPU features. Signed-off-by: Tim Chen --- arch/x86/kernel/cpu/microcode/core.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c inde