Re: [PATCH 7/8] ASoC: dapm: change snprintf to scnprintf for possible overflow

2019-01-15 Thread Willy Tarreau
On Tue, Jan 15, 2019 at 03:44:36PM +, Mark Brown wrote: > On Tue, Jan 15, 2019 at 04:16:15AM +0100, Willy Tarreau wrote: > > On Mon, Jan 14, 2019 at 02:56:50PM +, Mark Brown wrote: > > > On Sat, Jan 12, 2019 at 04:28:43PM +0100, Willy Tarreau wrote: > > > > I don't have a cover letter or a

Re: [PATCH 7/8] ASoC: dapm: change snprintf to scnprintf for possible overflow

2019-01-15 Thread Mark Brown
On Tue, Jan 15, 2019 at 04:16:15AM +0100, Willy Tarreau wrote: > On Mon, Jan 14, 2019 at 02:56:50PM +, Mark Brown wrote: > > On Sat, Jan 12, 2019 at 04:28:43PM +0100, Willy Tarreau wrote: > > I don't have a cover letter or anything before this in the series. > > What's going on with dependenci

Re: [PATCH 7/8] ASoC: dapm: change snprintf to scnprintf for possible overflow

2019-01-14 Thread Willy Tarreau
Hi Mark, On Mon, Jan 14, 2019 at 02:56:50PM +, Mark Brown wrote: > On Sat, Jan 12, 2019 at 04:28:43PM +0100, Willy Tarreau wrote: > > From: Silvio Cesare > > > > Change snprintf to scnprintf. There are generally two cases where using > > snprintf causes problems. > > I don't have a cover le

Re: [PATCH 7/8] ASoC: dapm: change snprintf to scnprintf for possible overflow

2019-01-14 Thread Mark Brown
On Sat, Jan 12, 2019 at 04:28:43PM +0100, Willy Tarreau wrote: > From: Silvio Cesare > > Change snprintf to scnprintf. There are generally two cases where using > snprintf causes problems. I don't have a cover letter or anything before this in the series. What's going on with dependencies here?

[PATCH 7/8] ASoC: dapm: change snprintf to scnprintf for possible overflow

2019-01-12 Thread Willy Tarreau
From: Silvio Cesare Change snprintf to scnprintf. There are generally two cases where using snprintf causes problems. 1) Uses of size += snprintf(buf, SIZE - size, fmt, ...) In this case, if snprintf would have written more characters than what the buffer size (SIZE) is, then size will end up la