Re: [PATCH 7/8] firmware: vpd: remove platform driver

2017-05-24 Thread Dmitry Torokhov
On Wed, May 24, 2017 at 05:04:41PM -0700, Julius Werner wrote: > I'm not a kernel expert so maybe I don't understand this right, but... > I think this might have been done this way to ensure that the driver > can get initialized correctly regardless of probe ordering. > coreboot_table_find() may

Re: [PATCH 7/8] firmware: vpd: remove platform driver

2017-05-24 Thread Dmitry Torokhov
On Wed, May 24, 2017 at 05:04:41PM -0700, Julius Werner wrote: > I'm not a kernel expert so maybe I don't understand this right, but... > I think this might have been done this way to ensure that the driver > can get initialized correctly regardless of probe ordering. > coreboot_table_find() may

Re: [PATCH 7/8] firmware: vpd: remove platform driver

2017-05-24 Thread Julius Werner
I'm not a kernel expert so maybe I don't understand this right, but... I think this might have been done this way to ensure that the driver can get initialized correctly regardless of probe ordering. coreboot_table_find() may fail with -EPROBE_DEFER if the coreboot_table driver and its dependent

Re: [PATCH 7/8] firmware: vpd: remove platform driver

2017-05-24 Thread Julius Werner
I'm not a kernel expert so maybe I don't understand this right, but... I think this might have been done this way to ensure that the driver can get initialized correctly regardless of probe ordering. coreboot_table_find() may fail with -EPROBE_DEFER if the coreboot_table driver and its dependent

Re: [PATCH 7/8] firmware: vpd: remove platform driver

2017-05-24 Thread Guenter Roeck
On Tue, May 23, 2017 at 5:07 PM, Dmitry Torokhov wrote: > There is no reason why VPD should register platform device and driver, > given that we do not use their respective kobjects to attach attributes, > nor do we need suspend/resume hooks, or any other features of

Re: [PATCH 7/8] firmware: vpd: remove platform driver

2017-05-24 Thread Guenter Roeck
On Tue, May 23, 2017 at 5:07 PM, Dmitry Torokhov wrote: > There is no reason why VPD should register platform device and driver, > given that we do not use their respective kobjects to attach attributes, > nor do we need suspend/resume hooks, or any other features of device > core. > >

[PATCH 7/8] firmware: vpd: remove platform driver

2017-05-23 Thread Dmitry Torokhov
There is no reason why VPD should register platform device and driver, given that we do not use their respective kobjects to attach attributes, nor do we need suspend/resume hooks, or any other features of device core. Signed-off-by: Dmitry Torokhov ---

[PATCH 7/8] firmware: vpd: remove platform driver

2017-05-23 Thread Dmitry Torokhov
There is no reason why VPD should register platform device and driver, given that we do not use their respective kobjects to attach attributes, nor do we need suspend/resume hooks, or any other features of device core. Signed-off-by: Dmitry Torokhov --- drivers/firmware/google/vpd.c | 44