Re: [PATCH 7/8] lguest: trivial guest block driver

2007-02-12 Thread Jens Axboe
On Tue, Feb 13 2007, Rusty Russell wrote: > On Mon, 2007-02-12 at 16:01 +0100, Jens Axboe wrote: > > On Mon, Feb 12 2007, Rusty Russell wrote: > > > Thanks Jens!! > > > > My pleasure, it's not often you get to make that big a performance > > improvement with just a little few lines of change :-) >

Re: [PATCH 7/8] lguest: trivial guest block driver

2007-02-12 Thread Rusty Russell
On Mon, 2007-02-12 at 16:01 +0100, Jens Axboe wrote: > On Mon, Feb 12 2007, Rusty Russell wrote: > > Thanks Jens!! > > My pleasure, it's not often you get to make that big a performance > improvement with just a little few lines of change :-) *cough* I deliberately leave these low hanging fruit i

Re: [PATCH 7/8] lguest: trivial guest block driver

2007-02-12 Thread Jens Axboe
On Mon, Feb 12 2007, Rusty Russell wrote: > On Mon, 2007-02-12 at 06:32 +0100, Jens Axboe wrote: > > On Mon, Feb 12 2007, Rusty Russell wrote: > > > On Mon, 2007-02-12 at 05:43 +0100, Jens Axboe wrote: > > > > Here you map the entire request (lets call that segment A..Z), but > > > > end_request()

Re: [PATCH 7/8] lguest: trivial guest block driver

2007-02-11 Thread Rusty Russell
On Mon, 2007-02-12 at 06:32 +0100, Jens Axboe wrote: > On Mon, Feb 12 2007, Rusty Russell wrote: > > On Mon, 2007-02-12 at 05:43 +0100, Jens Axboe wrote: > > > Here you map the entire request (lets call that segment A..Z), but > > > end_request() only completes the first chunk of the request. So >

Re: [PATCH 7/8] lguest: trivial guest block driver

2007-02-11 Thread Jens Axboe
On Mon, Feb 12 2007, Jens Axboe wrote: > On Mon, Feb 12 2007, Rusty Russell wrote: > > On Mon, 2007-02-12 at 05:43 +0100, Jens Axboe wrote: > > > On Mon, Feb 12 2007, Rusty Russell wrote: > > > > + end_request(bd->req, bd->lb_page->result == 1); > > > > > > You are using the old-style end req

Re: [PATCH 7/8] lguest: trivial guest block driver

2007-02-11 Thread Jens Axboe
On Mon, Feb 12 2007, Rusty Russell wrote: > On Mon, 2007-02-12 at 05:43 +0100, Jens Axboe wrote: > > On Mon, Feb 12 2007, Rusty Russell wrote: > > > + end_request(bd->req, bd->lb_page->result == 1); > > > > You are using the old-style end request handling. So while I generally > > discourage use of

Re: [PATCH 7/8] lguest: trivial guest block driver

2007-02-11 Thread Rusty Russell
On Mon, 2007-02-12 at 05:43 +0100, Jens Axboe wrote: > On Mon, Feb 12 2007, Rusty Russell wrote: > > + end_request(bd->req, bd->lb_page->result == 1); > > You are using the old-style end request handling. So while I generally > discourage use of end_request(), you seem to have a bigger problem he

Re: [PATCH 7/8] lguest: trivial guest block driver

2007-02-11 Thread Jens Axboe
On Mon, Feb 12 2007, Rusty Russell wrote: > +static irqreturn_t lgb_irq(int irq, void *_bd) > +{ > + struct blockdev *bd = _bd; > + unsigned long flags; > + > + if (!bd->req) { > + pr_debug("No work!\n"); > + return IRQ_NONE; > + } > + > + if (!bd->lb_pag

[PATCH 7/8] lguest: trivial guest block driver

2007-02-11 Thread Rusty Russell
A simple block driver for lguest (/dev/lgbX). Only does one request at once. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> === --- a/drivers/block/Makefile +++ b/drivers/block/Makefile @@ -28,4 +28,5 @@ obj-$(CONFIG_VIODASD)