Re: [PATCH 7/8] pstore/ram: Make tracing log versioned

2012-07-17 Thread Anton Vorontsov
On Tue, Jul 17, 2012 at 09:56:01AM -0700, Greg Kroah-Hartman wrote: [...] > That's nice, but it breaks the build on my system as linux_banner > somehow isn't enabled as part of the build? I really don't see how you managed to disable it. :-) init/version.c is built unconditionally, and it has

Re: [PATCH 7/8] pstore/ram: Make tracing log versioned

2012-07-17 Thread Anton Vorontsov
On Tue, Jul 17, 2012 at 09:56:01AM -0700, Greg Kroah-Hartman wrote: [...] > > In this patch we're just passing linux_banner through CRC32. > > That's nice, but it breaks the build on my system as linux_banner > somehow isn't enabled as part of the build? Hm... I'll take a look, thanks a lot! --

Re: [PATCH 7/8] pstore/ram: Make tracing log versioned

2012-07-17 Thread Greg Kroah-Hartman
On Mon, Jul 09, 2012 at 05:10:45PM -0700, Anton Vorontsov wrote: > Decoding the binary trace w/ a different kernel might be troublesome > since we convert addresses to symbols. For kernels with minimal changes, > the mappings would probably match, but it's not guaranteed at all. > (But still we

Re: [PATCH 7/8] pstore/ram: Make tracing log versioned

2012-07-17 Thread Greg Kroah-Hartman
On Mon, Jul 09, 2012 at 05:10:45PM -0700, Anton Vorontsov wrote: Decoding the binary trace w/ a different kernel might be troublesome since we convert addresses to symbols. For kernels with minimal changes, the mappings would probably match, but it's not guaranteed at all. (But still we could

Re: [PATCH 7/8] pstore/ram: Make tracing log versioned

2012-07-17 Thread Anton Vorontsov
On Tue, Jul 17, 2012 at 09:56:01AM -0700, Greg Kroah-Hartman wrote: [...] In this patch we're just passing linux_banner through CRC32. That's nice, but it breaks the build on my system as linux_banner somehow isn't enabled as part of the build? Hm... I'll take a look, thanks a lot! --

Re: [PATCH 7/8] pstore/ram: Make tracing log versioned

2012-07-17 Thread Anton Vorontsov
On Tue, Jul 17, 2012 at 09:56:01AM -0700, Greg Kroah-Hartman wrote: [...] That's nice, but it breaks the build on my system as linux_banner somehow isn't enabled as part of the build? I really don't see how you managed to disable it. :-) init/version.c is built unconditionally, and it has

[PATCH 7/8] pstore/ram: Make tracing log versioned

2012-07-09 Thread Anton Vorontsov
Decoding the binary trace w/ a different kernel might be troublesome since we convert addresses to symbols. For kernels with minimal changes, the mappings would probably match, but it's not guaranteed at all. (But still we could convert the addresses by hand, since we do print raw addresses.) If

[PATCH 7/8] pstore/ram: Make tracing log versioned

2012-07-09 Thread Anton Vorontsov
Decoding the binary trace w/ a different kernel might be troublesome since we convert addresses to symbols. For kernels with minimal changes, the mappings would probably match, but it's not guaranteed at all. (But still we could convert the addresses by hand, since we do print raw addresses.) If