Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-16 Thread Lee Jones
> I think it would be best if this got merged through whatever tree that > was used to introduce ab8500_irq_get_virq(); otherwise it will have to > wait till I resync with mainline sometime in the middle of the next > release cycle. I agree. Sam that's you, patch below. :) From: Lee Jones Date:

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-16 Thread Lee Jones
I think it would be best if this got merged through whatever tree that was used to introduce ab8500_irq_get_virq(); otherwise it will have to wait till I resync with mainline sometime in the middle of the next release cycle. I agree. Sam that's you, patch below. :) From: Lee Jones

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-14 Thread Linus Walleij
On Fri, Jul 13, 2012 at 3:43 PM, Lee Jones wrote: > On 10/07/12 22:08, Linus Walleij wrote: >> That's not enough, cat /dev/input/event/* whatever event node is used >> by the ponkey, press it and verify you get some garbage (=events) >> in the console. > > Yes, garbage seen, works fine. OK!

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-14 Thread Linus Walleij
On Fri, Jul 13, 2012 at 3:43 PM, Lee Jones lee.jo...@linaro.org wrote: On 10/07/12 22:08, Linus Walleij wrote: That's not enough, cat /dev/input/event/* whatever event node is used by the ponkey, press it and verify you get some garbage (=events) in the console. Yes, garbage seen, works

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-13 Thread Lee Jones
On 10/07/12 22:08, Linus Walleij wrote: On Mon, Jul 9, 2012 at 11:21 PM, Lee Jones wrote: On 09/07/12 23:03, Linus Walleij wrote: Now since I was fooled by the last patch, thinking you had tested it before submitting (obviously not) - please send a test log of some cat /dev/input/event* for

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-13 Thread Lee Jones
On 10/07/12 22:08, Linus Walleij wrote: On Mon, Jul 9, 2012 at 11:21 PM, Lee Jones lee.jo...@linaro.org wrote: On 09/07/12 23:03, Linus Walleij wrote: Now since I was fooled by the last patch, thinking you had tested it before submitting (obviously not) - please send a test log of some cat

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-12 Thread Mark Brown
On Tue, Jul 10, 2012 at 11:08:39PM +0200, Linus Walleij wrote: > On Mon, Jul 9, 2012 at 11:21 PM, Lee Jones wrote: > > I did test it, but must have only looked at the one IRQ incrementing. > That's not enough, cat /dev/input/event/* whatever event node is used > by the ponkey, press it and

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-12 Thread Mark Brown
On Tue, Jul 10, 2012 at 11:08:39PM +0200, Linus Walleij wrote: On Mon, Jul 9, 2012 at 11:21 PM, Lee Jones lee.jo...@linaro.org wrote: I did test it, but must have only looked at the one IRQ incrementing. That's not enough, cat /dev/input/event/* whatever event node is used by the ponkey,

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-10 Thread Linus Walleij
On Mon, Jul 9, 2012 at 11:21 PM, Lee Jones wrote: > On 09/07/12 23:03, Linus Walleij wrote: >> Now since I was fooled by the last patch, thinking you had tested it >> before >> submitting (obviously not) - please send a test log of some >> cat /dev/input/event* for this one before I ACK it this

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-10 Thread Lee Jones
On 10/07/12 08:17, Dmitry Torokhov wrote: On Mon, Jul 09, 2012 at 10:59:43PM +0200, Lee Jones wrote: Sorry for the cock-up(s). From: Lee Jones Date: Tue, 26 Jun 2012 10:46:50 +0100 Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Before we can use any domain

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-10 Thread Dmitry Torokhov
On Mon, Jul 09, 2012 at 10:59:43PM +0200, Lee Jones wrote: > Sorry for the cock-up(s). > > From: Lee Jones > Date: Tue, 26 Jun 2012 10:46:50 +0100 > Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping > > Before we can use any domain allocated IRQ, we need to first

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-10 Thread Dmitry Torokhov
On Mon, Jul 09, 2012 at 10:59:43PM +0200, Lee Jones wrote: Sorry for the cock-up(s). From: Lee Jones lee.jo...@linaro.org Date: Tue, 26 Jun 2012 10:46:50 +0100 Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Before we can use any domain allocated IRQ, we need

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-10 Thread Lee Jones
On 10/07/12 08:17, Dmitry Torokhov wrote: On Mon, Jul 09, 2012 at 10:59:43PM +0200, Lee Jones wrote: Sorry for the cock-up(s). From: Lee Jones lee.jo...@linaro.org Date: Tue, 26 Jun 2012 10:46:50 +0100 Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Before we can

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-10 Thread Linus Walleij
On Mon, Jul 9, 2012 at 11:21 PM, Lee Jones lee.jo...@linaro.org wrote: On 09/07/12 23:03, Linus Walleij wrote: Now since I was fooled by the last patch, thinking you had tested it before submitting (obviously not) - please send a test log of some cat /dev/input/event* for this one before I

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Lee Jones
On 09/07/12 23:03, Linus Walleij wrote: On Mon, Jul 9, 2012 at 10:59 PM, Lee Jones wrote: Before we can use any domain allocated IRQ, we need to first create a map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ (virq). We do this with a helper function provided by the AB8500 IRQ

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Linus Walleij
On Mon, Jul 9, 2012 at 10:59 PM, Lee Jones wrote: > Before we can use any domain allocated IRQ, we need to first create a > map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ (virq). > We do this with a helper function provided by the AB8500 IRQ domain > controller called

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Lee Jones
Sorry for the cock-up(s). From: Lee Jones Date: Tue, 26 Jun 2012 10:46:50 +0100 Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Before we can use any domain allocated IRQ, we need to first create a map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Lee Jones
On 09/07/12 22:46, Dmitry Torokhov wrote: On Mon, Jul 09, 2012 at 10:35:48PM +0200, Lee Jones wrote: From: Lee Jones Date: Tue, 26 Jun 2012 10:46:50 +0100 Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Before we can use any domain allocated IRQ, we need to first

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Dmitry Torokhov
On Mon, Jul 09, 2012 at 10:35:48PM +0200, Lee Jones wrote: > From: Lee Jones > Date: Tue, 26 Jun 2012 10:46:50 +0100 > Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping > > Before we can use any domain allocated IRQ, we need to first create a > map between the Hardware

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Lee Jones
On 09/07/12 22:37, Linus Walleij wrote: On Mon, Jul 9, 2012 at 10:35 PM, Lee Jones wrote: From: Lee Jones Date: Tue, 26 Jun 2012 10:46:50 +0100 Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Before we can use any domain allocated IRQ, we need to first create a

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Linus Walleij
On Mon, Jul 9, 2012 at 10:35 PM, Lee Jones wrote: > From: Lee Jones > Date: Tue, 26 Jun 2012 10:46:50 +0100 > Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping > > Before we can use any domain allocated IRQ, we need to first create a > map between the Hardware IRQ

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Lee Jones
From: Lee Jones Date: Tue, 26 Jun 2012 10:46:50 +0100 Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Before we can use any domain allocated IRQ, we need to first create a map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ (virq). We do this with a helper

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Lee Jones
Why do you keep these assignments and then override them with translations? Why don't you do ponkey->idev = input; ponkey->ab8500 = ab8500; ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, irq_dbf); ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, irq_dbr); to begin

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Dmitry Torokhov
On Mon, Jul 09, 2012 at 08:53:01PM +0200, Lee Jones wrote: > From: Lee Jones > Date: Tue, 26 Jun 2012 10:46:50 +0100 > Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping > > Before we can use any domain allocated IRQ, we need to first create a > map between the Hardware

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Lee Jones
From: Lee Jones Date: Tue, 26 Jun 2012 10:46:50 +0100 Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Before we can use any domain allocated IRQ, we need to first create a map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ (virq). We do this with a helper

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Lee Jones
From: Lee Jones lee.jo...@linaro.org Date: Tue, 26 Jun 2012 10:46:50 +0100 Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Before we can use any domain allocated IRQ, we need to first create a map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ (virq). We do

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Dmitry Torokhov
On Mon, Jul 09, 2012 at 08:53:01PM +0200, Lee Jones wrote: From: Lee Jones lee.jo...@linaro.org Date: Tue, 26 Jun 2012 10:46:50 +0100 Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Before we can use any domain allocated IRQ, we need to first create a map between

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Lee Jones
Why do you keep these assignments and then override them with translations? Why don't you do ponkey-idev = input; ponkey-ab8500 = ab8500; ponkey-irq_dbf = ab8500_irq_get_virq(ab8500, irq_dbf); ponkey-irq_dbr = ab8500_irq_get_virq(ab8500, irq_dbr); to begin with?

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Lee Jones
From: Lee Jones lee.jo...@linaro.org Date: Tue, 26 Jun 2012 10:46:50 +0100 Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Before we can use any domain allocated IRQ, we need to first create a map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ (virq). We do

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Linus Walleij
On Mon, Jul 9, 2012 at 10:35 PM, Lee Jones lee.jo...@linaro.org wrote: From: Lee Jones lee.jo...@linaro.org Date: Tue, 26 Jun 2012 10:46:50 +0100 Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Before we can use any domain allocated IRQ, we need to first create a

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Lee Jones
On 09/07/12 22:37, Linus Walleij wrote: On Mon, Jul 9, 2012 at 10:35 PM, Lee Jones lee.jo...@linaro.org wrote: From: Lee Jones lee.jo...@linaro.org Date: Tue, 26 Jun 2012 10:46:50 +0100 Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Before we can use any domain

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Dmitry Torokhov
On Mon, Jul 09, 2012 at 10:35:48PM +0200, Lee Jones wrote: From: Lee Jones lee.jo...@linaro.org Date: Tue, 26 Jun 2012 10:46:50 +0100 Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Before we can use any domain allocated IRQ, we need to first create a map between

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Lee Jones
On 09/07/12 22:46, Dmitry Torokhov wrote: On Mon, Jul 09, 2012 at 10:35:48PM +0200, Lee Jones wrote: From: Lee Jones lee.jo...@linaro.org Date: Tue, 26 Jun 2012 10:46:50 +0100 Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Before we can use any domain allocated

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Lee Jones
Sorry for the cock-up(s). From: Lee Jones lee.jo...@linaro.org Date: Tue, 26 Jun 2012 10:46:50 +0100 Subject: [PATCH 1/1] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Before we can use any domain allocated IRQ, we need to first create a map between the Hardware IRQ (hwirq) and the

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Linus Walleij
On Mon, Jul 9, 2012 at 10:59 PM, Lee Jones lee.jo...@linaro.org wrote: Before we can use any domain allocated IRQ, we need to first create a map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ (virq). We do this with a helper function provided by the AB8500 IRQ domain controller

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-09 Thread Lee Jones
On 09/07/12 23:03, Linus Walleij wrote: On Mon, Jul 9, 2012 at 10:59 PM, Lee Jones lee.jo...@linaro.org wrote: Before we can use any domain allocated IRQ, we need to first create a map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ (virq). We do this with a helper function provided

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-06 Thread Dmitry Torokhov
Hi Lee, On Fri, Jul 06, 2012 at 08:52:43AM +0100, Lee Jones wrote: > Sorry Dmitry, looks like I missed you off of the CC list on this one. > > Here it is again: > > Before we can use any domain allocated IRQ, we need to first create a > map between the Hardware IRQ (hwirq) and the Linux Virtual

Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

2012-07-06 Thread Dmitry Torokhov
Hi Lee, On Fri, Jul 06, 2012 at 08:52:43AM +0100, Lee Jones wrote: Sorry Dmitry, looks like I missed you off of the CC list on this one. Here it is again: Before we can use any domain allocated IRQ, we need to first create a map between the Hardware IRQ (hwirq) and the Linux Virtual IRQ