Re: [PATCH 7/9] clocksource/drivers/cadence_ttc: Convert init function to return error

2016-06-01 Thread Daniel Lezcano
On 06/01/2016 04:36 PM, Sören Brinkmann wrote: Hi Daniel, Hi Soren, [ ... ] + err = clk_notifier_register(ttcce->ttc.clk, + &ttcce->ttc.clk_rate_change_nb); + if (err) { pr_warn("Unable to register clock notifier.\n"); +

Re: [PATCH 7/9] clocksource/drivers/cadence_ttc: Convert init function to return error

2016-06-01 Thread Sören Brinkmann
Hi Daniel, On Wed, 2016-06-01 at 10:34:50 +0200, Daniel Lezcano wrote: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and >make the system boot up correctly > > or > > - print an error a

[PATCH 7/9] clocksource/drivers/cadence_ttc: Convert init function to return error

2016-06-01 Thread Daniel Lezcano
The init functions do not return any error. They behave as the following: - panic, thus leading to a kernel crash while another timer may work and make the system boot up correctly or - print an error and let the caller unaware if the state of the system Change that by converting the init