Re: [PATCH 7/9 net-next] sunrpc: replace if/BUG by BUG_ON

2015-03-31 Thread Fabian Frederick
> On 31 March 2015 at 21:11 Julia Lawall wrote: > > > > > On Tue, 31 Mar 2015, Fabian Frederick wrote: > > > > > > > > On 30 March 2015 at 23:25 "J. Bruce Fields" wrote: > > > > > > > > > Huh, I thought this wasn't recommended: > > > > > >       

Re: [PATCH 7/9 net-next] sunrpc: replace if/BUG by BUG_ON

2015-03-31 Thread Julia Lawall
On Tue, 31 Mar 2015, Fabian Frederick wrote: > > > > On 30 March 2015 at 23:25 "J. Bruce Fields" wrote: > > > > > > Huh, I thought this wasn't recommended: > > > >       http://lkml.kernel.org/r/20040828125816.206ef7fa.a...@osdl.org > > > >       "I'd prefer that we not move code which has

Re: [PATCH 7/9 net-next] sunrpc: replace if/BUG by BUG_ON

2015-03-31 Thread Fabian Frederick
> On 30 March 2015 at 23:25 "J. Bruce Fields" wrote: > > > Huh, I thought this wasn't recommended: > >       http://lkml.kernel.org/r/20040828125816.206ef7fa.a...@osdl.org > >       "I'd prefer that we not move code which has side-effects into >       BUG_ONs" Thanks for the link, I wasn't

Re: [PATCH 7/9 net-next] sunrpc: replace if/BUG by BUG_ON

2015-03-31 Thread Fabian Frederick
On 30 March 2015 at 23:25 J. Bruce Fields bfie...@fieldses.org wrote: Huh, I thought this wasn't recommended:        http://lkml.kernel.org/r/20040828125816.206ef7fa.a...@osdl.org        I'd prefer that we not move code which has side-effects into        BUG_ONs Thanks for the link, I

Re: [PATCH 7/9 net-next] sunrpc: replace if/BUG by BUG_ON

2015-03-31 Thread Julia Lawall
On Tue, 31 Mar 2015, Fabian Frederick wrote: On 30 March 2015 at 23:25 J. Bruce Fields bfie...@fieldses.org wrote: Huh, I thought this wasn't recommended:        http://lkml.kernel.org/r/20040828125816.206ef7fa.a...@osdl.org        I'd prefer that we not move code which has

Re: [PATCH 7/9 net-next] sunrpc: replace if/BUG by BUG_ON

2015-03-31 Thread Fabian Frederick
On 31 March 2015 at 21:11 Julia Lawall julia.law...@lip6.fr wrote: On Tue, 31 Mar 2015, Fabian Frederick wrote: On 30 March 2015 at 23:25 J. Bruce Fields bfie...@fieldses.org wrote: Huh, I thought this wasn't recommended:        

Re: [PATCH 7/9 net-next] sunrpc: replace if/BUG by BUG_ON

2015-03-30 Thread J. Bruce Fields
Huh, I thought this wasn't recommended: http://lkml.kernel.org/r/20040828125816.206ef7fa.a...@osdl.org "I'd prefer that we not move code which has side-effects into BUG_ONs" --b. On Mon, Mar 30, 2015 at 11:13:15PM +0200, Fabian Frederick wrote: > Signed-off-by: Fabian

[PATCH 7/9 net-next] sunrpc: replace if/BUG by BUG_ON

2015-03-30 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- net/sunrpc/auth_gss/svcauth_gss.c | 9 +++-- net/sunrpc/svc_xprt.c | 3 +-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c index 1095be9..09f8a1c6 100644 ---

[PATCH 7/9 net-next] sunrpc: replace if/BUG by BUG_ON

2015-03-30 Thread Fabian Frederick
Signed-off-by: Fabian Frederick f...@skynet.be --- net/sunrpc/auth_gss/svcauth_gss.c | 9 +++-- net/sunrpc/svc_xprt.c | 3 +-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c index

Re: [PATCH 7/9 net-next] sunrpc: replace if/BUG by BUG_ON

2015-03-30 Thread J. Bruce Fields
Huh, I thought this wasn't recommended: http://lkml.kernel.org/r/20040828125816.206ef7fa.a...@osdl.org I'd prefer that we not move code which has side-effects into BUG_ONs --b. On Mon, Mar 30, 2015 at 11:13:15PM +0200, Fabian Frederick wrote: Signed-off-by: Fabian