Re: [PATCH 8/14] drivers/video/sunxvr2500.c: fix error return code

2012-08-23 Thread Florian Tobias Schandinat
On 08/19/2012 08:44 AM, Julia Lawall wrote: > From: Julia Lawall > > Initialize return variable before exiting on an error path. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > ( > if@p1 (\(ret < 0\|ret != 0\)) > {

[PATCH 8/14] drivers/video/sunxvr2500.c: fix error return code

2012-08-19 Thread Julia Lawall
From: Julia Lawall Initialize return variable before exiting on an error path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when !=