Re: [PATCH 8/14] i386 / Add a per cpu gdt accessor

2005-08-16 Thread Chris Wright
* Andi Kleen ([EMAIL PROTECTED]) wrote: > On Tue, Aug 16, 2005 at 05:07:36PM -0700, Chris Wright wrote: > > * Andi Kleen ([EMAIL PROTECTED]) wrote: > > > On Wed, Aug 10, 2005 at 09:56:40PM -0700, [EMAIL PROTECTED] wrote: > > > > Add an accessor function for getting the per-CPU gdt. Callee must >

Re: [PATCH 8/14] i386 / Add a per cpu gdt accessor

2005-08-16 Thread Andi Kleen
On Tue, Aug 16, 2005 at 05:07:36PM -0700, Chris Wright wrote: > * Andi Kleen ([EMAIL PROTECTED]) wrote: > > On Wed, Aug 10, 2005 at 09:56:40PM -0700, [EMAIL PROTECTED] wrote: > > > Add an accessor function for getting the per-CPU gdt. Callee must already > > > have the CPU. > > > > What is the ac

Re: [PATCH 8/14] i386 / Add a per cpu gdt accessor

2005-08-16 Thread Chris Wright
* Andi Kleen ([EMAIL PROTECTED]) wrote: > On Wed, Aug 10, 2005 at 09:56:40PM -0700, [EMAIL PROTECTED] wrote: > > Add an accessor function for getting the per-CPU gdt. Callee must already > > have the CPU. > > What is the accessor good for? > > It looks just like code obfuscation to me. Xen han

Re: [PATCH 8/14] i386 / Add a per cpu gdt accessor

2005-08-16 Thread H. Peter Anvin
Andi Kleen wrote: On Wed, Aug 10, 2005 at 09:56:40PM -0700, [EMAIL PROTECTED] wrote: Add an accessor function for getting the per-CPU gdt. Callee must already have the CPU. What is the accessor good for? It looks just like code obfuscation to me. He wants accessors so he can override t

Re: [PATCH 8/14] i386 / Add a per cpu gdt accessor

2005-08-16 Thread Andi Kleen
On Wed, Aug 10, 2005 at 09:56:40PM -0700, [EMAIL PROTECTED] wrote: > Add an accessor function for getting the per-CPU gdt. Callee must already > have the CPU. What is the accessor good for? It looks just like code obfuscation to me. -Andi - To unsubscribe from this list: send the line "unsubsc

Re: [PATCH 8/14] i386 / Add a per cpu gdt accessor

2005-08-10 Thread Chris Wright
* H. Peter Anvin ([EMAIL PROTECTED]) wrote: > Chris Wright wrote: > >* Zwane Mwaikambo ([EMAIL PROTECTED]) wrote: > >>On Wed, 10 Aug 2005 [EMAIL PROTECTED] wrote: > >>>Add an accessor function for getting the per-CPU gdt. Callee must > >>>already > >>>have the CPU. > >> > >>This one seems superfl

Re: [PATCH 8/14] i386 / Add a per cpu gdt accessor

2005-08-10 Thread Zachary Amsden
Zwane Mwaikambo wrote: On Wed, 10 Aug 2005 [EMAIL PROTECTED] wrote: Add an accessor function for getting the per-CPU gdt. Callee must already have the CPU. This one seems superfluous to me, does accessing it indirectly generate better code too? Thanks for the feedback. I beli

Re: [PATCH 8/14] i386 / Add a per cpu gdt accessor

2005-08-10 Thread Zwane Mwaikambo
On Wed, 10 Aug 2005, Zachary Amsden wrote: > Thanks for the feedback. I believe the binary compilation is the same. It is > superfluous in the sense that there is not yet a real use for it, but it is > needed for later developement. > > Xen requires page isolation of system data structures that

Re: [PATCH 8/14] i386 / Add a per cpu gdt accessor

2005-08-10 Thread H. Peter Anvin
Chris Wright wrote: * Zwane Mwaikambo ([EMAIL PROTECTED]) wrote: On Wed, 10 Aug 2005 [EMAIL PROTECTED] wrote: Add an accessor function for getting the per-CPU gdt. Callee must already have the CPU. This one seems superfluous to me, does accessing it indirectly generate better code too?

Re: [PATCH 8/14] i386 / Add a per cpu gdt accessor

2005-08-10 Thread Chris Wright
* Zwane Mwaikambo ([EMAIL PROTECTED]) wrote: > On Wed, 10 Aug 2005 [EMAIL PROTECTED] wrote: > > > Add an accessor function for getting the per-CPU gdt. Callee must already > > have the CPU. > > This one seems superfluous to me, does accessing it indirectly generate > better code too? It's prep

Re: [PATCH 8/14] i386 / Add a per cpu gdt accessor

2005-08-10 Thread Zwane Mwaikambo
On Wed, 10 Aug 2005 [EMAIL PROTECTED] wrote: > Add an accessor function for getting the per-CPU gdt. Callee must already > have the CPU. This one seems superfluous to me, does accessing it indirectly generate better code too? > Patch-base: 2.6.13-rc5-mm1 > Patch-keys: i386 desc xen > Signed-of

[PATCH 8/14] i386 / Add a per cpu gdt accessor

2005-08-10 Thread zach
Add an accessor function for getting the per-CPU gdt. Callee must already have the CPU. Patch-base: 2.6.13-rc5-mm1 Patch-keys: i386 desc xen Signed-off-by: Zachary Amsden <[EMAIL PROTECTED]> Index: linux-2.6.13/include/asm-i386/desc.h ==