Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-18 Thread Naveen N. Rao
On 10/16/2013 04:19 PM, Borislav Petkov wrote: Btw, I don't know what's the problem but when I hit reply-to-all to your emails, mutt drops your email address from the To: and makes the CC: list become the To: list. Strange. I'm seeing the same thing. Looking at the headers, Chen Gong's email i

RE: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-17 Thread Luck, Tony
> There's also a third case: mirrored memories. Mirrors are currently something of a mess - we don't get any useful notification when one breaks. We do need to fix this - and make sure reporting is properly integrated with everything else - I'm just not sure how to do this. -Tony -- To unsubscr

Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-17 Thread Mauro Carvalho Chehab
Em Wed, 16 Oct 2013 20:47:05 + "Luck, Tony" escreveu: > > Also, I suspect that, if an error happens to affect more than one DIMM > > (e. g. part of the location is not available for a given error), > > that the DIMM label will also not be properly shown. > > There are a couple of cases here:

Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-17 Thread Mauro Carvalho Chehab
Em Wed, 16 Oct 2013 20:35:32 + "Luck, Tony" escreveu: > > Are there any changes with regards to that, like some enforcement policy > > for BIOS manufacturers to make it right? > > I am using a cricket bat to beat BIOS teams that implement eMCA to make > sure they get the labels in SMBIOS rig

RE: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-16 Thread Luck, Tony
> Also, I suspect that, if an error happens to affect more than one DIMM > (e. g. part of the location is not available for a given error), > that the DIMM label will also not be properly shown. There are a couple of cases here: 1) There are a number of DIMMs behind some flaky h/w that introduces

RE: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-16 Thread Luck, Tony
> Are there any changes with regards to that, like some enforcement policy > for BIOS manufacturers to make it right? I am using a cricket bat to beat BIOS teams that implement eMCA to make sure they get the labels in SMBIOS right. :-) It's a non-trivial implementation effort to get all the decod

Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-16 Thread Borislav Petkov
On Wed, Oct 16, 2013 at 08:55:58AM -0300, Mauro Carvalho Chehab wrote: > On that log, "physical addr: 0x000851fe node: 0 card: 0 module: 0 > rank: 0 bank: 0 row: 28927 column: 1296" > is a string, instead of an hierarchical position, like what it is provided > on EDAC. So you can't split

Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-16 Thread Mauro Carvalho Chehab
Em Wed, 16 Oct 2013 12:42:21 +0200 Borislav Petkov escreveu: > On Wed, Oct 16, 2013 at 07:35:39AM -0300, Mauro Carvalho Chehab wrote: > > Well, try to write some code on userspace to discover what's the error. > > > > An error threshold mechanism on userspace will only work if userspace > > kno

Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-16 Thread Borislav Petkov
Btw, I don't know what's the problem but when I hit reply-to-all to your emails, mutt drops your email address from the To: and makes the CC: list become the To: list. Strange. On Wed, Oct 16, 2013 at 05:50:30AM -0400, Chen Gong wrote: > This thread is so long. I have to say I'm lost ... Anyway, i

Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-16 Thread Borislav Petkov
On Wed, Oct 16, 2013 at 07:35:39AM -0300, Mauro Carvalho Chehab wrote: > Well, try to write some code on userspace to discover what's the error. > > An error threshold mechanism on userspace will only work if userspace > knows that the error belongs to the same DIMM. Just read the first mail aga

Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-16 Thread Mauro Carvalho Chehab
Em Wed, 16 Oct 2013 11:16:40 +0200 Borislav Petkov escreveu: > On Tue, Oct 15, 2013 at 09:43:46PM -0300, Mauro Carvalho Chehab wrote: > > > + const uuid_le *fru_id, > > Using a custom typedef here seems problematic, as that can make userspace > > interface more complicated. > It is defin

Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-16 Thread Chen Gong
msung.com > Subject: Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver > User-Agent: Mutt/1.5.21 (2010-09-15) > > On 2013/10/11 02:32AM, Chen Gong wrote: > > Use trace interface to elaborate all H/W error related > > information. > > > >

Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-16 Thread Borislav Petkov
On Tue, Oct 15, 2013 at 09:43:46PM -0300, Mauro Carvalho Chehab wrote: > Using a custom typedef here seems problematic, as that can make userspace > interface more complicated. It is defined in a userspace header: include/uapi/linux/uuid.h > > >>> + char *fru_text, > > >>> +

Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-15 Thread Mauro Carvalho Chehab
I see a few problems on this patchset: Em Tue, 15 Oct 2013 23:00:53 +0530 "Naveen N. Rao" escreveu: > On 10/15/2013 10:30 PM, Borislav Petkov wrote: > > On Tue, Oct 15, 2013 at 10:24:35PM +0530, Naveen N. Rao wrote: > >> On 2013/10/11 02:32AM, Chen Gong wrote: > >>> Use trace interface to elabor

Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-15 Thread Borislav Petkov
On Tue, Oct 15, 2013 at 11:00:53PM +0530, Naveen N. Rao wrote: > I thought the primary problem was the conflict with edac core itself. > So, if I'm not mistaken, we would have to prevent all edac drivers > from loading. That too - I don't see the need for them if the firmware does the decoding. -

Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-15 Thread Naveen N. Rao
On 10/15/2013 10:30 PM, Borislav Petkov wrote: On Tue, Oct 15, 2013 at 10:24:35PM +0530, Naveen N. Rao wrote: On 2013/10/11 02:32AM, Chen Gong wrote: Use trace interface to elaborate all H/W error related information. Signed-off-by: Chen, Gong --- +TRACE_EVENT(extlog_mem_event, + TP_

Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-15 Thread Borislav Petkov
On Tue, Oct 15, 2013 at 10:24:35PM +0530, Naveen N. Rao wrote: > On 2013/10/11 02:32AM, Chen Gong wrote: > > Use trace interface to elaborate all H/W error related > > information. > > > > Signed-off-by: Chen, Gong > > --- > > > +TRACE_EVENT(extlog_mem_event, > > + TP_PROTO(u32 etype, > > +

Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-15 Thread Naveen N. Rao
On 2013/10/11 02:32AM, Chen Gong wrote: > Use trace interface to elaborate all H/W error related > information. > > Signed-off-by: Chen, Gong > --- > +TRACE_EVENT(extlog_mem_event, > + TP_PROTO(u32 etype, > + char *dimm_loc, > + const uuid_le *fru_id, > +

Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-14 Thread Chen Gong
On Fri, Oct 11, 2013 at 06:14:36PM +0200, Borislav Petkov wrote: > Date: Fri, 11 Oct 2013 18:14:36 +0200 > From: Borislav Petkov > To: "Chen, Gong" > Cc: tony.l...@intel.com, linux-kernel@vger.kernel.org, > linux-a...@vger.kernel.org > Subject: Re: [PATCH 8/8] ACPI

Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-11 Thread Borislav Petkov
On Fri, Oct 11, 2013 at 02:32:46AM -0400, Chen, Gong wrote: > Use trace interface to elaborate all H/W error related > information. > > Signed-off-by: Chen, Gong > --- > drivers/acpi/Kconfig| 7 ++- > drivers/acpi/Makefile | 4 ++ > drivers/acpi/acpi_extlog.c | 28 +++

Re: [PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-11 Thread Borislav Petkov
On Fri, Oct 11, 2013 at 02:32:46AM -0400, Chen, Gong wrote: > diff --git a/drivers/acpi/extlog_trace.h b/drivers/acpi/extlog_trace.h > new file mode 100644 > index 000..21f0887 > --- /dev/null > +++ b/drivers/acpi/extlog_trace.h > @@ -0,0 +1,77 @@ > +#if !defined(_TRACE_EXTLOG_H) || defined(TRA

[PATCH 8/8] ACPI / trace: Add trace interface for eMCA driver

2013-10-10 Thread Chen, Gong
Use trace interface to elaborate all H/W error related information. Signed-off-by: Chen, Gong --- drivers/acpi/Kconfig| 7 ++- drivers/acpi/Makefile | 4 ++ drivers/acpi/acpi_extlog.c | 28 +++- drivers/acpi/apei/cper.c| 13 -- drivers/acpi/debug_extlog.h |