Hi Robert,
On Wed, Apr 01, 2015 at 06:35:31PM +0300, Robert Dolca wrote:
> On Thu, Mar 26, 2015 at 2:30 AM, Samuel Ortiz wrote:
> >> + /* If a patch was applied the new version is checked */
> >> + if (patched) {
> >> + r = nci_init(ndev);
> >> + if (r)
> >> +
On Thu, Mar 26, 2015 at 2:30 AM, Samuel Ortiz wrote:
>> + /* If a patch was applied the new version is checked */
>> + if (patched) {
>> + r = nci_init(ndev);
>> + if (r)
>> + goto error;
>> +
>> + r = fdp_nci_get_versions(ndev);
>> +
On Tue, Feb 24, 2015 at 12:01:52PM +0200, Robert Dolca wrote:
> +static struct i2c_device_id fdp_nci_i2c_id_table[] = {
> + {"INT339A", 0},
If this is ACPI only device you can remove the above line.
> + {}
> +};
> +
> +MODULE_DEVICE_TABLE(i2c, fdp_nci_i2c_id_table);
And this as well.
>
Robert,
Another comment:
On Tue, Feb 24, 2015 at 12:01:52PM +0200, Robert Dolca wrote:
> +static struct i2c_device_id fdp_nci_i2c_id_table[] = {
> + {"INT339A", 0},
> + {}
> +};
> +
> +MODULE_DEVICE_TABLE(i2c, fdp_nci_i2c_id_table);
> +
> +
> +static const struct acpi_device_id fdp_nci_i2
Hi Robert,
On Tue, Feb 24, 2015 at 12:01:52PM +0200, Robert Dolca wrote:
> The device can be enumerated using ACPI using the id INT339A.
Please give us some more details about the device. NCI ? HCI ?
Features ? What does the initial patchset support ?
> +config NFC_FDP
> + tristate "Intel FDP
On Tue, Feb 24, 2015 at 11:33:10AM +0100, Johannes Berg wrote:
> > +config NFC_FDP
> > + tristate "Intel FDP NFC driver"
> > + depends on NFC_NCI
> > + select CRC_CCITT
> > + default n
> > + ---help---
> > + Intel FDP core driver.
> > + This is a driver based on the NCI NFC kernel
I have no idea about NFC, but
> +config NFC_FDP
> + tristate "Intel FDP NFC driver"
> + depends on NFC_NCI
> + select CRC_CCITT
> + default n
> + ---help---
> + Intel FDP core driver.
> + This is a driver based on the NCI NFC kernel layers.
> +
> + To compile
The device can be enumerated using ACPI using the id INT339A.
The 1st GPIO is the IRQ and the 2nd is the RESET pin.
I can be also enumerated using platform init.
Signed-off-by: Robert Dolca
---
drivers/nfc/Kconfig | 1 +
drivers/nfc/fdp/Kconfig | 22 ++
drivers/nfc/fdp
8 matches
Mail list logo
