Re: [PATCH 8/8] gpio/mpc8xxx: Use of_mm_gpiochip_remove

2015-01-21 Thread Linus Walleij
On Sun, Jan 18, 2015 at 12:39 PM, Ricardo Ribalda Delgado wrote: > Since d621e8bae5ac9c67 (Create of_mm_gpiochip_remove), there is a > counterpart for of_mm_gpiochip_add. > > This patch implements the remove function of the driver making use of > it. > > Cc: Linus Walleij > Cc: Alexandre Courbot

Re: [PATCH 8/8] gpio/mpc8xxx: Use of_mm_gpiochip_remove

2015-01-20 Thread Peter Korsgaard
> "Ricardo" == Ricardo Ribalda Delgado writes: > Hello Peter >> >> > -hwirq = irq_of_parse_and_map(np, 0); >> > -if (hwirq == NO_IRQ) >> > +mpc8xxx_gc->irqn = irq_of_parse_and_map(np, 0); >> > +if (mpc8xxx_gc->irqn == NO_IRQ) >> > return 0; >> >> >> W

Re: [PATCH 8/8] gpio/mpc8xxx: Use of_mm_gpiochip_remove

2015-01-20 Thread Ricardo Ribalda Delgado
Hello Linus I am waiting from the confirmation of Peter if that is what he really needs. It seems to me that the code should continue even if there is no irqdomain created. If we need to abort if there is no irqdomain I would rather create a new patch with this change, since it it is a change o

Re: [PATCH 8/8] gpio/mpc8xxx: Use of_mm_gpiochip_remove

2015-01-20 Thread Linus Walleij
On Sun, Jan 18, 2015 at 12:39 PM, Ricardo Ribalda Delgado wrote: > Since d621e8bae5ac9c67 (Create of_mm_gpiochip_remove), there is a > counterpart for of_mm_gpiochip_add. > > This patch implements the remove function of the driver making use of > it. > > Cc: Linus Walleij > Cc: Alexandre Courbot

Re: [PATCH 8/8] gpio/mpc8xxx: Use of_mm_gpiochip_remove

2015-01-19 Thread Ricardo Ribalda Delgado
Hello Peter > > > -hwirq = irq_of_parse_and_map(np, 0); > > -if (hwirq == NO_IRQ) > > +mpc8xxx_gc->irqn = irq_of_parse_and_map(np, 0); > > +if (mpc8xxx_gc->irqn == NO_IRQ) > > return 0; > > > With this return 0 converted to do of_mm_gpiochip_remove(): Are you su

Re: [PATCH 8/8] gpio/mpc8xxx: Use of_mm_gpiochip_remove

2015-01-19 Thread Peter Korsgaard
> "Ricardo" == Ricardo Ribalda Delgado writes: > Since d621e8bae5ac9c67 (Create of_mm_gpiochip_remove), there is a > counterpart for of_mm_gpiochip_add. > This patch implements the remove function of the driver making use of > it. > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: P

[PATCH 8/8] gpio/mpc8xxx: Use of_mm_gpiochip_remove

2015-01-18 Thread Ricardo Ribalda Delgado
Since d621e8bae5ac9c67 (Create of_mm_gpiochip_remove), there is a counterpart for of_mm_gpiochip_add. This patch implements the remove function of the driver making use of it. Cc: Linus Walleij Cc: Alexandre Courbot Cc: Peter Korsgaard Signed-off-by: Ricardo Ribalda Delgado --- drivers/gpio/