Re: [PATCH 8/8] habanalabs: enable 64-bit DMA mask in POWER9

2019-06-11 Thread Christoph Hellwig
On Tue, Jun 11, 2019 at 08:50:45AM +0300, Oded Gabbay wrote: > 2. The pci_set_dma_mask() is a generic Linux kernel call, so the driver >can't tell why it got an error when it tried to set the DMA mask to 48 >bits. And upon such failure, the driver must fall-back to set the mask >to 32

Re: [PATCH 8/8] habanalabs: enable 64-bit DMA mask in POWER9

2019-06-11 Thread Oded Gabbay
On Tue, Jun 11, 2019 at 11:08 AM Oded Gabbay wrote: > > On Tue, Jun 11, 2019 at 10:59 AM Greg KH wrote: > > > > On Tue, Jun 11, 2019 at 08:50:45AM +0300, Oded Gabbay wrote: > > > --- a/drivers/misc/habanalabs/habanalabs_drv.c > > > +++ b/drivers/misc/habanalabs/habanalabs_drv.c > > > @@ -28,6

Re: [PATCH 8/8] habanalabs: enable 64-bit DMA mask in POWER9

2019-06-11 Thread Oded Gabbay
On Tue, Jun 11, 2019 at 10:59 AM Greg KH wrote: > > On Tue, Jun 11, 2019 at 08:50:45AM +0300, Oded Gabbay wrote: > > --- a/drivers/misc/habanalabs/habanalabs_drv.c > > +++ b/drivers/misc/habanalabs/habanalabs_drv.c > > @@ -28,6 +28,7 @@ static DEFINE_MUTEX(hl_devs_idr_lock); > > > > static int

Re: [PATCH 8/8] habanalabs: enable 64-bit DMA mask in POWER9

2019-06-11 Thread Greg KH
On Tue, Jun 11, 2019 at 08:50:45AM +0300, Oded Gabbay wrote: > --- a/drivers/misc/habanalabs/habanalabs_drv.c > +++ b/drivers/misc/habanalabs/habanalabs_drv.c > @@ -28,6 +28,7 @@ static DEFINE_MUTEX(hl_devs_idr_lock); > > static int timeout_locked = 5; > static int reset_on_lockup = 1; >

[PATCH 8/8] habanalabs: enable 64-bit DMA mask in POWER9

2019-06-10 Thread Oded Gabbay
This patch enables support in the driver for 64-bit DMA mask when running in a POWER9 machine. POWER9 supports either 32-bit or 64-bit DMA mask. However, our ASICs support 48-bit DMA mask. To support 64-bit, the driver needs to add a special configuration to the ASIC's PCIe controller. The