On 20/05/15 10:51, Jon Hunter wrote:
>
> On 20/05/15 04:57, Alexandre Courbot wrote:
>
> [snip]
>
>> There may still be a leak (that is not related to your patch) in the
>> RX path though:
>>
>> dma_buf = dma_alloc_coherent(...);
>> ret = dmaengine_slave_config(...);
>> if (ret <
On 20/05/15 04:57, Alexandre Courbot wrote:
[snip]
> There may still be a leak (that is not related to your patch) in the
> RX path though:
>
> dma_buf = dma_alloc_coherent(...);
> ret = dmaengine_slave_config(...);
> if (ret < 0) {
> ...
> goto scrub;
> }
>
>
On 20/05/15 04:57, Alexandre Courbot wrote:
[snip]
There may still be a leak (that is not related to your patch) in the
RX path though:
dma_buf = dma_alloc_coherent(...);
ret = dmaengine_slave_config(...);
if (ret 0) {
...
goto scrub;
}
On 20/05/15 10:51, Jon Hunter wrote:
On 20/05/15 04:57, Alexandre Courbot wrote:
[snip]
There may still be a leak (that is not related to your patch) in the
RX path though:
dma_buf = dma_alloc_coherent(...);
ret = dmaengine_slave_config(...);
if (ret 0) {
...
On Wed, May 13, 2015 at 5:23 PM, Jon Hunter wrote:
>
> On 13/05/15 05:56, Alexandre Courbot wrote:
>> On Tue, May 12, 2015 at 6:51 PM, Jon Hunter wrote:
>>>
>>> On 12/05/15 09:39, Alexandre Courbot wrote:
On Tue, May 5, 2015 at 11:17 PM, Jon Hunter wrote:
> Function
On Wed, May 13, 2015 at 5:23 PM, Jon Hunter jonath...@nvidia.com wrote:
On 13/05/15 05:56, Alexandre Courbot wrote:
On Tue, May 12, 2015 at 6:51 PM, Jon Hunter jonath...@nvidia.com wrote:
On 12/05/15 09:39, Alexandre Courbot wrote:
On Tue, May 5, 2015 at 11:17 PM, Jon Hunter
On 13/05/15 05:56, Alexandre Courbot wrote:
> On Tue, May 12, 2015 at 6:51 PM, Jon Hunter wrote:
>>
>> On 12/05/15 09:39, Alexandre Courbot wrote:
>>> On Tue, May 5, 2015 at 11:17 PM, Jon Hunter wrote:
Function tegra_uart_dma_channel_allocate() does not check that
dma_map_single()
On 13/05/15 05:56, Alexandre Courbot wrote:
On Tue, May 12, 2015 at 6:51 PM, Jon Hunter jonath...@nvidia.com wrote:
On 12/05/15 09:39, Alexandre Courbot wrote:
On Tue, May 5, 2015 at 11:17 PM, Jon Hunter jonath...@nvidia.com wrote:
Function tegra_uart_dma_channel_allocate() does not check
On Tue, May 12, 2015 at 6:51 PM, Jon Hunter wrote:
>
> On 12/05/15 09:39, Alexandre Courbot wrote:
>> On Tue, May 5, 2015 at 11:17 PM, Jon Hunter wrote:
>>> Function tegra_uart_dma_channel_allocate() does not check that
>>> dma_map_single() mapped the DMA buffer correctly. Add a check for this
On 12/05/15 09:39, Alexandre Courbot wrote:
> On Tue, May 5, 2015 at 11:17 PM, Jon Hunter wrote:
>> Function tegra_uart_dma_channel_allocate() does not check that
>> dma_map_single() mapped the DMA buffer correctly. Add a check for this
>> and appropriate error handling.
>>
>> Furthermore, if
On Tue, May 5, 2015 at 11:17 PM, Jon Hunter wrote:
> Function tegra_uart_dma_channel_allocate() does not check that
> dma_map_single() mapped the DMA buffer correctly. Add a check for this
> and appropriate error handling.
>
> Furthermore, if dmaengine_slave_config() (called by
>
On Tue, May 5, 2015 at 11:17 PM, Jon Hunter jonath...@nvidia.com wrote:
Function tegra_uart_dma_channel_allocate() does not check that
dma_map_single() mapped the DMA buffer correctly. Add a check for this
and appropriate error handling.
Furthermore, if dmaengine_slave_config() (called by
On 12/05/15 09:39, Alexandre Courbot wrote:
On Tue, May 5, 2015 at 11:17 PM, Jon Hunter jonath...@nvidia.com wrote:
Function tegra_uart_dma_channel_allocate() does not check that
dma_map_single() mapped the DMA buffer correctly. Add a check for this
and appropriate error handling.
On Tue, May 12, 2015 at 6:51 PM, Jon Hunter jonath...@nvidia.com wrote:
On 12/05/15 09:39, Alexandre Courbot wrote:
On Tue, May 5, 2015 at 11:17 PM, Jon Hunter jonath...@nvidia.com wrote:
Function tegra_uart_dma_channel_allocate() does not check that
dma_map_single() mapped the DMA buffer
Function tegra_uart_dma_channel_allocate() does not check that
dma_map_single() mapped the DMA buffer correctly. Add a check for this
and appropriate error handling.
Furthermore, if dmaengine_slave_config() (called by
tegra_uart_dma_channel_allocate()) fails, then memory allocated/mapped
is not
Function tegra_uart_dma_channel_allocate() does not check that
dma_map_single() mapped the DMA buffer correctly. Add a check for this
and appropriate error handling.
Furthermore, if dmaengine_slave_config() (called by
tegra_uart_dma_channel_allocate()) fails, then memory allocated/mapped
is not
16 matches
Mail list logo
