Re: [PATCH 8/8] usb: dwc3: Add Amlogic G12A DWC3 glue

2019-03-04 Thread Neil Armstrong
Hi, On 02/03/2019 11:29, Martin Blumenstingl wrote: > Hi Neil, > >>> +static int dwc3_meson_g12a_debugfs_init(struct dwc3_meson_g12a *priv) >>> +{ >>> + priv->root = debugfs_create_dir("dwc3-meson-g12a", NULL); >>> + if (IS_ERR(priv->root)) >>> + return

Re: [PATCH 8/8] usb: dwc3: Add Amlogic G12A DWC3 glue

2019-03-02 Thread Martin Blumenstingl
Hi Neil, > > +static int dwc3_meson_g12a_debugfs_init(struct dwc3_meson_g12a *priv) > > +{ > > + priv->root = debugfs_create_dir("dwc3-meson-g12a", NULL); > > + if (IS_ERR(priv->root)) > > + return PTR_ERR(priv->root); > > + > > + debugfs_create_file("mode_force",

Re: [PATCH 8/8] usb: dwc3: Add Amlogic G12A DWC3 glue

2019-02-24 Thread Martin Blumenstingl
Hi Neil, thank you for working on this! I have few questions and comments below, but overall it looks good :) On Tue, Feb 12, 2019 at 4:17 PM Neil Armstrong wrote: > > Adds support for Amlogic G12A USB Control Glue HW. > > The Amlogic G12A SoC Family embeds 2 USB Controllers : > - a DWC3 IP

[PATCH 8/8] usb: dwc3: Add Amlogic G12A DWC3 glue

2019-02-12 Thread Neil Armstrong
Adds support for Amlogic G12A USB Control Glue HW. The Amlogic G12A SoC Family embeds 2 USB Controllers : - a DWC3 IP configured as Host for USB2 and USB3 - a DWC2 IP configured as Peripheral USB2 Only A glue connects these both controllers to 2 USB2 PHYs, and optionnally to an USB3+PCIE Combo