Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence

2019-03-29 Thread Alex Williamson
vger.kernel.org; linux- > >> ker...@vger.kernel.org; alex.william...@redhat.com > >> Cc: Neo Jia > >> Subject: Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence > >> > >> > >> > >> On 3/23/2019 4:50 AM, Parav Pandit wrote:

Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence

2019-03-28 Thread Kirti Wankhede
t; Cc: Neo Jia >> Subject: Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence >> >> >> >> On 3/23/2019 4:50 AM, Parav Pandit wrote: >>> There are five problems with current code structure. >>> 1. mdev device is placed on the mdev bus befo

RE: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence

2019-03-26 Thread Parav Pandit
Hi Alex, > -Original Message- > From: Alex Williamson > Sent: Tuesday, March 26, 2019 10:27 AM > To: Kirti Wankhede > Cc: Parav Pandit ; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; Neo Jia > Subject: Re: [PATCH 8/8] vfio/mdev: Improve the create/remove

RE: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence

2019-03-26 Thread Parav Pandit
> -Original Message- > From: Kirti Wankhede > Sent: Tuesday, March 26, 2019 2:06 AM > To: Parav Pandit ; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; alex.william...@redhat.com > Cc: Neo Jia > Subject: Re: [PATCH 8/8] vfio/mdev: Improve the c

Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence

2019-03-26 Thread Alex Williamson
On Tue, 26 Mar 2019 12:36:22 +0530 Kirti Wankhede wrote: > On 3/23/2019 4:50 AM, Parav Pandit wrote: > > There are five problems with current code structure. > > 1. mdev device is placed on the mdev bus before it is created in the > > vendor driver. Once a device is placed on the mdev bus without

Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence

2019-03-26 Thread Alex Williamson
: k...@vger.kernel.org; linux-kernel@vger.kernel.org; > > kwankh...@nvidia.com > > Subject: RE: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence > > > > > > > > > -Original Message- > > > From: Alex Williamson > > > Sent:

Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence

2019-03-26 Thread Kirti Wankhede
On 3/23/2019 4:50 AM, Parav Pandit wrote: > There are five problems with current code structure. > 1. mdev device is placed on the mdev bus before it is created in the > vendor driver. Once a device is placed on the mdev bus without creating > its supporting underlying vendor device, an open() c

RE: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence

2019-03-25 Thread Parav Pandit
Subject: RE: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence > > > > > -Original Message- > > From: Alex Williamson > > Sent: Monday, March 25, 2019 9:17 PM > > To: Parav Pandit > > Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;

RE: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence

2019-03-25 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Monday, March 25, 2019 9:17 PM > To: Parav Pandit > Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org; > kwankh...@nvidia.com > Subject: Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence >

Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence

2019-03-25 Thread Alex Williamson
onday, March 25, 2019 6:19 PM > > > > To: Parav Pandit > > > > Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > kwankh...@nvidia.com > > > > Subject: Re: [PATCH 8/8] vfio/mdev: Improve the create/remove > > > > sequence &g

RE: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence

2019-03-25 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Monday, March 25, 2019 7:06 PM > To: Parav Pandit > Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org; > kwankh...@nvidia.com > Subject: Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence >

Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence

2019-03-25 Thread Alex Williamson
om > > Subject: Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence > > > > On Fri, 22 Mar 2019 18:20:35 -0500 > > Parav Pandit wrote: > > > > > There are five problems with current code structure. > > > 1. mdev device is placed on the

RE: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence

2019-03-25 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Monday, March 25, 2019 6:19 PM > To: Parav Pandit > Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org; > kwankh...@nvidia.com > Subject: Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence >

Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence

2019-03-25 Thread Alex Williamson
On Fri, 22 Mar 2019 18:20:35 -0500 Parav Pandit wrote: > There are five problems with current code structure. > 1. mdev device is placed on the mdev bus before it is created in the > vendor driver. Once a device is placed on the mdev bus without creating > its supporting underlying vendor device,

RE: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence

2019-03-25 Thread Parav Pandit
> -Original Message- > From: Maxim Levitsky > Sent: Monday, March 25, 2019 8:24 AM > To: Parav Pandit ; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; kwankh...@nvidia.com; > alex.william...@redhat.com > Subject: Re: [PATCH 8/8] vfio/mdev: Improve the c

Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence

2019-03-25 Thread Maxim Levitsky
On Fri, 2019-03-22 at 18:20 -0500, Parav Pandit wrote: > There are five problems with current code structure. > 1. mdev device is placed on the mdev bus before it is created in the > vendor driver. Once a device is placed on the mdev bus without creating > its supporting underlying vendor device, a

[PATCH 8/8] vfio/mdev: Improve the create/remove sequence

2019-03-22 Thread Parav Pandit
There are five problems with current code structure. 1. mdev device is placed on the mdev bus before it is created in the vendor driver. Once a device is placed on the mdev bus without creating its supporting underlying vendor device, an open() can get triggered by userspace on partially initialize