The references in the is_uvX_hub() function uses the hub_info pointer
which will be NULL when the system is hubless. This change avoids
that NULL dereference. It is also an optimization in performance.
Signed-off-by: Mike Travis
Reviewed-by: Steve Wahl
Reviewed-by: Dimitri Sivanich
To: Thomas
The references in the is_uvX_hub() function uses the hub_info pointer
which will be NULL when the system is hubless. This change avoids
that NULL dereference. It is also an optimization in performance.
Signed-off-by: Mike Travis
Reviewed-by: Steve Wahl
Reviewed-by: Dimitri Sivanich
To: Thomas
Hi Christoph,
I can do these and leave some comments as markers to find the code to
remove later. The real problem is uv_mmrs.h is a generated file and the
scripts cannot be easily redone. Basically they copy in the verilog
definition files from the UV HUB design files and create kernel
com
On Tue, Sep 03, 2019 at 11:58:49AM -0700, Mike Travis wrote:
> Those ifdefs are not dead code and are being actively used. Plus UV1
> support is dead and I think the last running system died about a year ago
> and no support or parts are available. So undef'ing these macros will
> simplify and re
On 9/3/2019 11:58 AM, Mike Travis wrote:
On 9/3/2019 9:19 AM, Christoph Hellwig wrote:
On Mon, Sep 02, 2019 at 07:18:23PM -0500, Mike Travis wrote:
+#ifdef UV1_HUB_IS_SUPPORTED
All these ifdefs are dead code, please just remove them.
Those ifdefs are not dead code and are being acti
On 9/3/2019 9:19 AM, Christoph Hellwig wrote:
On Mon, Sep 02, 2019 at 07:18:23PM -0500, Mike Travis wrote:
+#ifdef UV1_HUB_IS_SUPPORTED
All these ifdefs are dead code, please just remove them.
Those ifdefs are not dead code and are being actively used. Plus UV1
support is dead and I thi
On Mon, Sep 02, 2019 at 07:18:23PM -0500, Mike Travis wrote:
> +#ifdef UV1_HUB_IS_SUPPORTED
All these ifdefs are dead code, please just remove them.
Also it seems like at least the various mmr macros just check
for a specific version, I think you are much better off just
using a switch stat
The references in the is_uvX_hub() function uses the hub_info pointer
which will be NULL when the system is hubless. This change avoids
that NULL dereference. It is also an optimization in performance.
Signed-off-by: Mike Travis
Reviewed-by: Steve Wahl
Reviewed-by: Dimitri Sivanich
---
arch/
8 matches
Mail list logo
