Re: [PATCH 8/9] ARM: kernel: add support for cpu cache information

2014-06-27 Thread Sudeep Holla
Hi, On 26/06/14 19:45, Stephen Boyd wrote: On 06/26/14 04:36, Sudeep Holla wrote: Hi Stephen, On 26/06/14 01:19, Stephen Boyd wrote: On 06/25/14 10:30, Sudeep Holla wrote: + +/* + * Which cache CCSIDR represents depends on CSSELR value + * Make sure no one else changes CSSELR during this + *

Re: [PATCH 8/9] ARM: kernel: add support for cpu cache information

2014-06-26 Thread Stephen Boyd
On 06/26/14 04:36, Sudeep Holla wrote: > Hi Stephen, > > On 26/06/14 01:19, Stephen Boyd wrote: >> On 06/25/14 10:30, Sudeep Holla wrote: >>> + >>> +/* >>> + * Which cache CCSIDR represents depends on CSSELR value >>> + * Make sure no one else changes CSSELR during this >>> + * smp_call_function_si

Re: [PATCH 8/9] ARM: kernel: add support for cpu cache information

2014-06-26 Thread Sudeep Holla
Hi Stephen, On 26/06/14 01:19, Stephen Boyd wrote: On 06/25/14 10:30, Sudeep Holla wrote: + +/* + * Which cache CCSIDR represents depends on CSSELR value + * Make sure no one else changes CSSELR during this + * smp_call_function_single prevents preemption for us + */ Where's the smp_call_func

Re: [PATCH 8/9] ARM: kernel: add support for cpu cache information

2014-06-26 Thread Sudeep Holla
Hi Russell, Thanks for the reviews. On 25/06/14 23:33, Russell King - ARM Linux wrote: On Wed, Jun 25, 2014 at 06:30:43PM +0100, Sudeep Holla wrote: [...] + +#include +#include +#include +#include +#include + +#include +#include + +#if __LINUX_ARM_ARCH__ < 7 /* pre ARMv7 */ __LINUX_A

Re: [PATCH 8/9] ARM: kernel: add support for cpu cache information

2014-06-25 Thread Stephen Boyd
On 06/25/14 10:30, Sudeep Holla wrote: > + > +/* > + * Which cache CCSIDR represents depends on CSSELR value > + * Make sure no one else changes CSSELR during this > + * smp_call_function_single prevents preemption for us > + */ Where's the smp_call_function_single() or preemption disable happenin

Re: [PATCH 8/9] ARM: kernel: add support for cpu cache information

2014-06-25 Thread Russell King - ARM Linux
On Wed, Jun 25, 2014 at 06:30:43PM +0100, Sudeep Holla wrote: > diff --git a/arch/arm/kernel/Makefile b/arch/arm/kernel/Makefile > index 38ddd9f..2c5ff0e 100644 > --- a/arch/arm/kernel/Makefile > +++ b/arch/arm/kernel/Makefile > @@ -29,6 +29,7 @@ obj-y += entry-v7m.o v7m.o > else >

[PATCH 8/9] ARM: kernel: add support for cpu cache information

2014-06-25 Thread Sudeep Holla
From: Sudeep Holla This patch adds support for cacheinfo on ARM platforms. On ARMv7, the cache hierarchy can be identified through Cache Level ID register(CLIDR) while the cache geometry is provided by Cache Size ID register(CCSIDR). On architecture versions before ARMv7, CLIDR and CCSIDR is no