On Wed, Nov 08, 2017 at 05:25:20PM -0600, Andrew F. Davis wrote:
> On 11/08/2017 04:18 PM, Mark Brown wrote:
> > There is code in the driver to use the GPIO, including in the probe
> > where the GPIO is requested and set to high (which will bring it out of
> > reset if the default state was low).
On 11/08/2017 04:18 PM, Mark Brown wrote:
> On Wed, Nov 08, 2017 at 03:53:51PM -0600, Andrew F. Davis wrote:
>> On 11/08/2017 03:36 PM, Mark Brown wrote:
>>> On Wed, Nov 08, 2017 at 03:25:04PM -0600, Andrew F. Davis wrote:
>
>>> This is obviously an incompatible change in the binding which will br
On Wed, Nov 08, 2017 at 03:53:51PM -0600, Andrew F. Davis wrote:
> On 11/08/2017 03:36 PM, Mark Brown wrote:
> > On Wed, Nov 08, 2017 at 03:25:04PM -0600, Andrew F. Davis wrote:
> > This is obviously an incompatible change in the binding which will break
> > any production DTs relying on the curre
On 11/08/2017 03:36 PM, Mark Brown wrote:
> On Wed, Nov 08, 2017 at 03:25:04PM -0600, Andrew F. Davis wrote:
>
>> -ret = of_get_named_gpio(np, "gpio-reset", 0);
>> +ret = of_get_named_gpio(np, "reset-gpio", 0);
>
> This is obviously an incompatible change in the binding which will break
>
On Wed, Nov 08, 2017 at 03:25:04PM -0600, Andrew F. Davis wrote:
> - ret = of_get_named_gpio(np, "gpio-reset", 0);
> + ret = of_get_named_gpio(np, "reset-gpio", 0);
This is obviously an incompatible change in the binding which will break
any production DTs relying on the current behaviour
The correct DT property for specifying a GPIO used for reset
is "reset-gpio", fix this here.
Fixes: e00447fafbf7 ("ASoC: tlv320aic31xx: Add basic codec driver
implementation")
Signed-off-by: Andrew F. Davis
---
sound/soc/codecs/tlv320aic31xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
6 matches
Mail list logo
