Re: [PATCH 8/9] nvme-pci: break up nvme_timeout and nvme_dev_disable

Hi Sagi Just make some supplement here. On 02/12/2018 10:16 AM, jianchao.wang wrote: >> I think this is going in the wrong direction. Every state that is needed >> to handle serialization should be done in core ctrl state. Moreover, >> please try to avoid handling this locally in nvme-pci, place

Re: [PATCH 8/9] nvme-pci: break up nvme_timeout and nvme_dev_disable

Hi Sagi Thanks for your kindly remind and directive. That's really appreciated. On 02/11/2018 07:36 PM, Sagi Grimberg wrote: > Jianchao, > >> Currently, the complicated relationship between nvme_dev_disable >> and nvme_timeout has become a devil that will introduce many >> circular pattern which

Re: [PATCH 8/9] nvme-pci: break up nvme_timeout and nvme_dev_disable

Jianchao, Currently, the complicated relationship between nvme_dev_disable and nvme_timeout has become a devil that will introduce many circular pattern which may trigger deadlock or IO hang. Let's enumerate the tangles between them: - nvme_timeout has to invoke nvme_dev_disable to stop the

[PATCH 8/9] nvme-pci: break up nvme_timeout and nvme_dev_disable

Currently, the complicated relationship between nvme_dev_disable and nvme_timeout has become a devil that will introduce many circular pattern which may trigger deadlock or IO hang. Let's enumerate the tangles between them: - nvme_timeout has to invoke nvme_dev_disable to stop the controller do