On Tue, Oct 30, 2007 at 04:32:35PM +0100, Roel Kluin wrote:
> Jesper Nilsson wrote:
> > + if (np->mii_if.phy_id == 32)
> > return -ENODEV;
> You need to unlock before this return.
Thanks for spotting this!
/^JN - Jesper Nilsson
--
Jesper Nilsson -- [EMAIL PROTECTED]
On Tue, Oct 30, 2007 at 04:32:35PM +0100, Roel Kluin wrote:
Jesper Nilsson wrote:
+ if (np-mii_if.phy_id == 32)
return -ENODEV;
You need to unlock before this return.
Thanks for spotting this!
/^JN - Jesper Nilsson
--
Jesper Nilsson -- [EMAIL PROTECTED]
-
To
On Tue, 30 Oct 2007 10:32:31 +0100
Jesper Nilsson <[EMAIL PROTECTED]> wrote:
> New (updated) version of ethernet driver for cris v10.
This driver (and this patch) contain a large number of trivial
coding-style glitches. Please always pass the diffs through
scripts/checkpatch.pl and review the
Jesper Nilsson wrote:
> static int
> e100_probe_transceiver(struct net_device* dev)
> {
> +#if !defined(CONFIG_ETRAX_NO_PHY)
> unsigned int phyid_high;
> unsigned int phyid_low;
> unsigned int oui;
> struct transceiver_ops* ops = NULL;
> + struct net_local *np =
New (updated) version of ethernet driver for cris v10.
- First steps to simplify and make the MII code more similar
between the etrax100 and etraxfs ports.
- Start the transmit queue before enabling tx interrupts
to avoid race with the first frame.
- Flip the comparition statement to stick
New (updated) version of ethernet driver for cris v10.
- First steps to simplify and make the MII code more similar
between the etrax100 and etraxfs ports.
- Start the transmit queue before enabling tx interrupts
to avoid race with the first frame.
- Flip the comparition statement to stick
Jesper Nilsson wrote:
static int
e100_probe_transceiver(struct net_device* dev)
{
+#if !defined(CONFIG_ETRAX_NO_PHY)
unsigned int phyid_high;
unsigned int phyid_low;
unsigned int oui;
struct transceiver_ops* ops = NULL;
+ struct net_local *np =
On Tue, 30 Oct 2007 10:32:31 +0100
Jesper Nilsson [EMAIL PROTECTED] wrote:
New (updated) version of ethernet driver for cris v10.
This driver (and this patch) contain a large number of trivial
coding-style glitches. Please always pass the diffs through
scripts/checkpatch.pl and review the
8 matches
Mail list logo