Re: [PATCH 9/7] sched,numa: remove task_h_load from task_numa_compare

2014-06-24 Thread Peter Zijlstra
On Wed, Jun 25, 2014 at 01:39:27AM -0400, Rik van Riel wrote: > > Here it goes: > > When CONFIG_FAIR_GROUP_SCHED is enabled, the load that a task places > on a CPU is determined by the group the task is in. The active groups > on the source and destination CPU can be different, resulting in a > d

Re: [PATCH 9/7] sched,numa: remove task_h_load from task_numa_compare

2014-06-24 Thread Rik van Riel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/25/2014 01:31 AM, Peter Zijlstra wrote: > On Wed, Jun 25, 2014 at 01:25:00AM -0400, Rik van Riel wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> On 06/25/2014 01:21 AM, Peter Zijlstra wrote: >>> On Wed, Jun 25, 2014 at 07:07:35AM +

Re: [PATCH 9/7] sched,numa: remove task_h_load from task_numa_compare

2014-06-24 Thread Peter Zijlstra
On Wed, Jun 25, 2014 at 01:25:00AM -0400, Rik van Riel wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 06/25/2014 01:21 AM, Peter Zijlstra wrote: > > On Wed, Jun 25, 2014 at 07:07:35AM +0200, Peter Zijlstra wrote: > >> Shall I merge this into patch 3? > > > > Which gets me the bel

Re: [PATCH 9/7] sched,numa: remove task_h_load from task_numa_compare

2014-06-24 Thread Rik van Riel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/25/2014 01:21 AM, Peter Zijlstra wrote: > On Wed, Jun 25, 2014 at 07:07:35AM +0200, Peter Zijlstra wrote: >> Shall I merge this into patch 3? > > Which gets me the below; which is has a wrong changelog. > > task_h_load() already computes the lo

Re: [PATCH 9/7] sched,numa: remove task_h_load from task_numa_compare

2014-06-24 Thread Peter Zijlstra
On Wed, Jun 25, 2014 at 07:07:35AM +0200, Peter Zijlstra wrote: > Shall I merge this into patch 3? Which gets me the below; which is has a wrong changelog. task_h_load() already computes the load as seen from the root group. effective_load() just does a better (and more expensive) job of computin

Re: [PATCH 9/7] sched,numa: remove task_h_load from task_numa_compare

2014-06-24 Thread Rik van Riel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/25/2014 01:07 AM, Peter Zijlstra wrote: > On Tue, Jun 24, 2014 at 03:14:54PM -0400, Rik van Riel wrote: >> The function effective_load already makes the calculations that >> task_h_load makes. Making them twice can throw off the >> calculations,

Re: [PATCH 9/7] sched,numa: remove task_h_load from task_numa_compare

2014-06-24 Thread Peter Zijlstra
On Tue, Jun 24, 2014 at 03:14:54PM -0400, Rik van Riel wrote: > The function effective_load already makes the calculations that > task_h_load makes. Making them twice can throw off the calculations, > and is generally a bad idea. > > Signed-off-by: Rik van Riel > --- > kernel/sched/fair.c | 4 ++

[PATCH 9/7] sched,numa: remove task_h_load from task_numa_compare

2014-06-24 Thread Rik van Riel
The function effective_load already makes the calculations that task_h_load makes. Making them twice can throw off the calculations, and is generally a bad idea. Signed-off-by: Rik van Riel --- kernel/sched/fair.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/sch