On Mon, 31 Jan 2005 09:03:44 -0800, Matt Mackall <[EMAIL PROTECTED]> wrote:
> It's a nice self-contained unit test. It's here because I ran into a
> strange regparm-related bug when developing the code in userspace and
> I wanted to be sure that it was easy to diagnose in the field if a
> similar b
Matt Mackall wrote:
> It's a nice self-contained unit test.
By the way, I think it would be useful if there was a more
formalized frame for such unit tests, so that they could be used
in automated kernel testing.
To avoid false positives when grepping through the code, perhaps
such tests could be
Matt wrote:
> I actually think that more code
> ought to have such tests, so long as they don't obscure the code in
> question.
If all the little unit tests that had ever been coded for kernel code
were embedded in "#if 0 ... #endif" sections, it _would_ obscure the
code.
To the local maintainer
On Mon, Jan 31, 2005 at 03:57:42AM -0800, Paul Jackson wrote:
> How about just removing the self test, not "#if 0"'ing it out.
>
> Better to keep the kernel source code clean of development
> scaffolding.
>
> Though your patch 1/8 hasn't arrived in my email inbox yet,
> so I don't actually know w
On Mon, 2005-01-31 at 12:57, Paul Jackson wrote:
> How about just removing the self test, not "#if 0"'ing it out.
I agree with that.
-- Andreas.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://
How about just removing the self test, not "#if 0"'ing it out.
Better to keep the kernel source code clean of development
scaffolding.
Though your patch 1/8 hasn't arrived in my email inbox yet,
so I don't actually know what 'self test' code it is that
I am speaking of ;).
--
Doh.
Signed-off-by: Matt Mackall <[EMAIL PROTECTED]>
Index: mm2/lib/sort.c
===
--- mm2.orig/lib/sort.c 2005-01-30 22:37:28.0 -0800
+++ mm2/lib/sort.c 2005-01-30 23:41:40.0 -0800
@@ -82,7 +82,7 @@
MODULE_LICENS
7 matches
Mail list logo
