On Nov 23 2007 11:47, Joe Perches wrote:
>On Fri, 2007-11-23 at 19:16 +0100, Jan Engelhardt wrote:
>> static inline bool xfs_inode_clean(const struct xfs_inode *ip)
>> {
>> if (ip->i_itemp == NULL)
>> return true;
>> if (!(ip->i_itemp->ili_format.ilf_fields & XFS_ILOG_ALL) &
On Fri, 2007-11-23 at 19:16 +0100, Jan Engelhardt wrote:
> static inline bool xfs_inode_clean(const struct xfs_inode *ip)
> {
> if (ip->i_itemp == NULL)
> return true;
> if (!(ip->i_itemp->ili_format.ilf_fields & XFS_ILOG_ALL) &&
> ip->i_update_core == NULL)
>
On Nov 23 2007 18:02, Christoph Hellwig wrote:
>
>> +STATIC_INLINE int xfs_inode_clean(xfs_inode_t *ip)
>> +{
>> +return (((ip->i_itemp == NULL) ||
>> +!(ip->i_itemp->ili_format.ilf_fields & XFS_ILOG_ALL)) &&
>> +(ip->i_update_core == 0));
>> +}
>
>Can we please get rid
> +STATIC_INLINE int xfs_inode_clean(xfs_inode_t *ip)
> +{
> + return (((ip->i_itemp == NULL) ||
> + !(ip->i_itemp->ili_format.ilf_fields & XFS_ILOG_ALL)) &&
> + (ip->i_update_core == 0));
> +}
Can we please get rid of this useless STATIC_INLINE junk? It's really
hurti
Use xfs_inode_clean() in more places.
Signed-off-by: Dave Chinner <[EMAIL PROTECTED]>
---
fs/xfs/xfs_inode.c | 27 +--
fs/xfs/xfs_inode_item.h |8
fs/xfs/xfs_vnodeops.c |4 +---
3 files changed, 14 insertions(+), 25 deletions(-)
Index: 2.6.x-xfs-
5 matches
Mail list logo