Re: [PATCH 9/9] aio: implement IOCB_CMD_FSYNC and IOCB_CMD_FDSYNC

2018-03-21 Thread Darrick J. Wong
On Wed, Mar 21, 2018 at 08:32:32AM +0100, Christoph Hellwig wrote: > Simple workqueue offload for now, but prepared for adding a real aio_fsync > method if the need arises. Based on an earlier patch from Dave Chinner. > > Signed-off-by: Christoph Hellwig Looks ok, Reviewed-by: Darrick J. Wong

Re: [PATCH 9/9] aio: implement IOCB_CMD_FSYNC and IOCB_CMD_FDSYNC

2018-03-21 Thread Christoph Hellwig
On Wed, Mar 21, 2018 at 10:27:13AM +0100, Greg KH wrote: > I hate the "bool" arguments to functions as you always need to go back > and look them up. A "wrapper" of "aio_fsync_datasync()" and > "aio_fsync_nodatasync()" around this maybe? This is how the fsync API works. Wrappers really don't hel

Re: [PATCH 9/9] aio: implement IOCB_CMD_FSYNC and IOCB_CMD_FDSYNC

2018-03-21 Thread Greg KH
On Wed, Mar 21, 2018 at 08:32:32AM +0100, Christoph Hellwig wrote: > Simple workqueue offload for now, but prepared for adding a real aio_fsync > method if the need arises. Based on an earlier patch from Dave Chinner. > > Signed-off-by: Christoph Hellwig > --- > fs/aio.c | 50 ++

[PATCH 9/9] aio: implement IOCB_CMD_FSYNC and IOCB_CMD_FDSYNC

2018-03-21 Thread Christoph Hellwig
Simple workqueue offload for now, but prepared for adding a real aio_fsync method if the need arises. Based on an earlier patch from Dave Chinner. Signed-off-by: Christoph Hellwig --- fs/aio.c | 50 ++ 1 file changed, 50 insertions(+) diff --git