Re: [PATCH 9/9] clocksource: import ARC timer driver

On 11/03/2016 10:33 AM, Daniel Lezcano wrote: > As now the clksrc-probe is correctly handling the errors, if the rtc and the > gfrc are both defined in the DT, you can fail to init the rtc one with a > simple > test in the init function: > > if (IS_DEFINED(CONFIG_SMP)) >

Re: [PATCH 9/9] clocksource: import ARC timer driver

On 11/03/2016 10:33 AM, Daniel Lezcano wrote: > As now the clksrc-probe is correctly handling the errors, if the rtc and the > gfrc are both defined in the DT, you can fail to init the rtc one with a > simple > test in the init function: > > if (IS_DEFINED(CONFIG_SMP)) >

Re: [PATCH 9/9] clocksource: import ARC timer driver

On 11/03/2016 11:11 AM, Daniel Lezcano wrote: >> Thx for taking a quick look - this is a good start. How about the actual >> driver >> > itself, do you want to take a quick look there as well before v2 ? > At the first glance, with your changes it is acceptable to be moved. Perhaps, > you can

Re: [PATCH 9/9] clocksource: import ARC timer driver

On 11/03/2016 11:11 AM, Daniel Lezcano wrote: >> Thx for taking a quick look - this is a good start. How about the actual >> driver >> > itself, do you want to take a quick look there as well before v2 ? > At the first glance, with your changes it is acceptable to be moved. Perhaps, > you can

Re: [PATCH 9/9] clocksource: import ARC timer driver

On Thu, Nov 03, 2016 at 06:33:17PM +0100, Daniel Lezcano wrote: [ ... ] > As now the clksrc-probe is correctly handling the errors, if the rtc and the > gfrc are both defined in the DT, you can fail to init the rtc one with a > simple > test in the init function: > > if

Re: [PATCH 9/9] clocksource: import ARC timer driver

On Thu, Nov 03, 2016 at 06:33:17PM +0100, Daniel Lezcano wrote: [ ... ] > As now the clksrc-probe is correctly handling the errors, if the rtc and the > gfrc are both defined in the DT, you can fail to init the rtc one with a > simple > test in the init function: > > if

Re: [PATCH 9/9] clocksource: import ARC timer driver

On Thu, Nov 03, 2016 at 10:57:48AM -0700, Vineet Gupta wrote: > Hi Daniel, > > On 11/03/2016 09:50 AM, Daniel Lezcano wrote: > > On Thu, Nov 03, 2016 at 09:40:23AM -0700, Vineet Gupta wrote: > >> On 11/01/2016 06:03 PM, Vineet Gupta wrote: > > Because of the git mv you, diff didn't include

Re: [PATCH 9/9] clocksource: import ARC timer driver

On Thu, Nov 03, 2016 at 10:57:48AM -0700, Vineet Gupta wrote: > Hi Daniel, > > On 11/03/2016 09:50 AM, Daniel Lezcano wrote: > > On Thu, Nov 03, 2016 at 09:40:23AM -0700, Vineet Gupta wrote: > >> On 11/01/2016 06:03 PM, Vineet Gupta wrote: > > Because of the git mv you, diff didn't include

Re: [PATCH 9/9] clocksource: import ARC timer driver

Hi Daniel, On 11/03/2016 09:50 AM, Daniel Lezcano wrote: > On Thu, Nov 03, 2016 at 09:40:23AM -0700, Vineet Gupta wrote: >> On 11/01/2016 06:03 PM, Vineet Gupta wrote: > Because of the git mv you, diff didn't include bulk of driver code which > would >>> make for bulk of review

Re: [PATCH 9/9] clocksource: import ARC timer driver

Hi Daniel, On 11/03/2016 09:50 AM, Daniel Lezcano wrote: > On Thu, Nov 03, 2016 at 09:40:23AM -0700, Vineet Gupta wrote: >> On 11/01/2016 06:03 PM, Vineet Gupta wrote: > Because of the git mv you, diff didn't include bulk of driver code which > would >>> make for bulk of review

Re: [PATCH 9/9] clocksource: import ARC timer driver

On Tue, Nov 01, 2016 at 01:57:05PM -0700, Vineet Gupta wrote: > Hi Daniel, > > On 11/01/2016 01:42 PM, Daniel Lezcano wrote: > > Please stay consistent with the rest of the Kconfig. > > > > config ARC_TIMER_RTC > > bool "64-bit cycle counter in HS38 cores" if COMPILE_TEST > > select

Re: [PATCH 9/9] clocksource: import ARC timer driver

On Tue, Nov 01, 2016 at 01:57:05PM -0700, Vineet Gupta wrote: > Hi Daniel, > > On 11/01/2016 01:42 PM, Daniel Lezcano wrote: > > Please stay consistent with the rest of the Kconfig. > > > > config ARC_TIMER_RTC > > bool "64-bit cycle counter in HS38 cores" if COMPILE_TEST > > select

Re: [PATCH 9/9] clocksource: import ARC timer driver

On Thu, Nov 03, 2016 at 09:40:23AM -0700, Vineet Gupta wrote: > On 11/01/2016 06:03 PM, Vineet Gupta wrote: > >>> Because of the git mv you, diff didn't include bulk of driver code which > >>> would > >>> >> make for bulk of review anyways. So perhaps in v2 I don't do the git > >>> >> mv. OK ? >

Re: [PATCH 9/9] clocksource: import ARC timer driver

On Thu, Nov 03, 2016 at 09:40:23AM -0700, Vineet Gupta wrote: > On 11/01/2016 06:03 PM, Vineet Gupta wrote: > >>> Because of the git mv you, diff didn't include bulk of driver code which > >>> would > >>> >> make for bulk of review anyways. So perhaps in v2 I don't do the git > >>> >> mv. OK ? >

Re: [PATCH 9/9] clocksource: import ARC timer driver

On 11/01/2016 06:03 PM, Vineet Gupta wrote: >>> Because of the git mv you, diff didn't include bulk of driver code which >>> would >>> >> make for bulk of review anyways. So perhaps in v2 I don't do the git mv. >>> >> OK ? >> > >> > That means I will review and comment existing code. It is not

Re: [PATCH 9/9] clocksource: import ARC timer driver

On 11/01/2016 06:03 PM, Vineet Gupta wrote: >>> Because of the git mv you, diff didn't include bulk of driver code which >>> would >>> >> make for bulk of review anyways. So perhaps in v2 I don't do the git mv. >>> >> OK ? >> > >> > That means I will review and comment existing code. It is not

Re: [PATCH 9/9] clocksource: import ARC timer driver

On 11/01/2016 05:19 PM, Daniel Lezcano wrote: >>> >>> One question: >>> >>> Why ARC_TIMER_RTC can't be used in a SMP system ? Doesn't have each core its >>> own clocksource ? It seems you are assuming a clocksource can be used on SMP >>> only if the clocksource is unique and shared across the

Re: [PATCH 9/9] clocksource: import ARC timer driver

On 11/01/2016 05:19 PM, Daniel Lezcano wrote: >>> >>> One question: >>> >>> Why ARC_TIMER_RTC can't be used in a SMP system ? Doesn't have each core its >>> own clocksource ? It seems you are assuming a clocksource can be used on SMP >>> only if the clocksource is unique and shared across the

Re: [PATCH 9/9] clocksource: import ARC timer driver

On Tue, Nov 01, 2016 at 01:57:05PM -0700, Vineet Gupta wrote: > Hi Daniel, > > On 11/01/2016 01:42 PM, Daniel Lezcano wrote: > > Please stay consistent with the rest of the Kconfig. > > > > config ARC_TIMER_RTC > > bool "64-bit cycle counter in HS38 cores" if COMPILE_TEST > > select

Re: [PATCH 9/9] clocksource: import ARC timer driver

On Tue, Nov 01, 2016 at 01:57:05PM -0700, Vineet Gupta wrote: > Hi Daniel, > > On 11/01/2016 01:42 PM, Daniel Lezcano wrote: > > Please stay consistent with the rest of the Kconfig. > > > > config ARC_TIMER_RTC > > bool "64-bit cycle counter in HS38 cores" if COMPILE_TEST > > select

Re: [PATCH 9/9] clocksource: import ARC timer driver

Hi Daniel, On 11/01/2016 01:42 PM, Daniel Lezcano wrote: > Please stay consistent with the rest of the Kconfig. > > config ARC_TIMER_RTC > bool "64-bit cycle counter in HS38 cores" if COMPILE_TEST > select CLKSRC_OF > help > This counter provides 64-bit resolution vs.

Re: [PATCH 9/9] clocksource: import ARC timer driver

Hi Daniel, On 11/01/2016 01:42 PM, Daniel Lezcano wrote: > Please stay consistent with the rest of the Kconfig. > > config ARC_TIMER_RTC > bool "64-bit cycle counter in HS38 cores" if COMPILE_TEST > select CLKSRC_OF > help > This counter provides 64-bit resolution vs.

Re: [PATCH 9/9] clocksource: import ARC timer driver

On Mon, Oct 31, 2016 at 03:48:16PM -0700, Vineet Gupta wrote: > Signed-off-by: Vineet Gupta > --- > MAINTAINERS| 1 + > arch/arc/Kconfig | 12 + > arch/arc/kernel/Makefile

Re: [PATCH 9/9] clocksource: import ARC timer driver

On Mon, Oct 31, 2016 at 03:48:16PM -0700, Vineet Gupta wrote: > Signed-off-by: Vineet Gupta > --- > MAINTAINERS| 1 + > arch/arc/Kconfig | 12 + > arch/arc/kernel/Makefile | 2 +- >

Re: [PATCH 9/9] clocksource: import ARC timer driver

On 10/31/2016 05:01 PM, kbuild test robot wrote: > Hi Vineet, > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.9-rc3] > [cannot apply to arc/for-next] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > [Suggest to

Re: [PATCH 9/9] clocksource: import ARC timer driver

On 10/31/2016 05:01 PM, kbuild test robot wrote: > Hi Vineet, > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.9-rc3] > [cannot apply to arc/for-next] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > [Suggest to

Re: [PATCH 9/9] clocksource: import ARC timer driver

Hi Vineet, [auto build test ERROR on linus/master] [also build test ERROR on v4.9-rc3] [cannot apply to arc/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for

Re: [PATCH 9/9] clocksource: import ARC timer driver

Hi Vineet, [auto build test ERROR on linus/master] [also build test ERROR on v4.9-rc3] [cannot apply to arc/for-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for

[PATCH 9/9] clocksource: import ARC timer driver

Signed-off-by: Vineet Gupta --- MAINTAINERS| 1 + arch/arc/Kconfig | 12 + arch/arc/kernel/Makefile | 2 +- drivers/clocksource/Kconfig| 24

[PATCH 9/9] clocksource: import ARC timer driver

Signed-off-by: Vineet Gupta --- MAINTAINERS| 1 + arch/arc/Kconfig | 12 + arch/arc/kernel/Makefile | 2 +- drivers/clocksource/Kconfig| 24 ++