Re: [PATCH 9/9] perf, tools, record: Always allow to overide default period v2

2014-06-08 Thread Namhyung Kim
On Wed, 4 Jun 2014 09:59:30 -0700, Andi Kleen wrote: > I saw samples. > > Oh well we can just drop it. The only difference is that the > event list cannot set a period then. I tested with a downloaded event, and it does have samples. But the frequency could not be changed even with your patch.

Re: [PATCH 9/9] perf, tools, record: Always allow to overide default period v2

2014-06-04 Thread Andi Kleen
I saw samples. Oh well we can just drop it. The only difference is that the event list cannot set a period then. It's as broken as before. -Andi -- a...@linux.intel.com -- Speaking for myself only -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mess

Re: [PATCH 9/9] perf, tools, record: Always allow to overide default period v2

2014-06-04 Thread Namhyung Kim
Hi Andi, 2014-05-30 (금), 14:50 -0700, Andi Kleen: > From: Andi Kleen > > Fix the logic to allow overriding event default periods with -c or -F > on the command line. I'm not sure I understand this if() fully, but > this change makes all cases I tested work (tracepoint with default, default, > ,

[PATCH 9/9] perf, tools, record: Always allow to overide default period v2

2014-05-30 Thread Andi Kleen
From: Andi Kleen Fix the logic to allow overriding event default periods with -c or -F on the command line. I'm not sure I understand this if() fully, but this change makes all cases I tested work (tracepoint with default, default, ,-c, -F) This fixed specifying -c / -F with json event list eve

[PATCH 9/9] perf, tools, record: Always allow to overide default period v2

2014-05-15 Thread Andi Kleen
From: Andi Kleen Fix the logic to allow overriding event default periods with -c or -F on the command line. I'm not sure I understand this if() fully, but this change makes all cases I tested work (tracepoint with default, default, ,-c, -F) This fixed specifying -c / -F with json event list eve

Re: [PATCH 9/9] perf, tools, record: Always allow to overide default period v2

2014-05-15 Thread Andi Kleen
On Wed, May 14, 2014 at 02:50:47PM +0900, Namhyung Kim wrote: > On Mon, 12 May 2014 15:51:14 -0700, Andi Kleen wrote: > > From: Andi Kleen > > > > Fix the logic to allow overriding event default periods with -c or -F > > on the command line. I'm not sure I understand this if() fully, but > > this

Re: [PATCH 9/9] perf, tools, record: Always allow to overide default period v2

2014-05-13 Thread Namhyung Kim
On Mon, 12 May 2014 15:51:14 -0700, Andi Kleen wrote: > From: Andi Kleen > > Fix the logic to allow overriding event default periods with -c or -F > on the command line. I'm not sure I understand this if() fully, but > this change makes all cases I tested work (tracepoint with default, default, >

[PATCH 9/9] perf, tools, record: Always allow to overide default period v2

2014-05-12 Thread Andi Kleen
From: Andi Kleen Fix the logic to allow overriding event default periods with -c or -F on the command line. I'm not sure I understand this if() fully, but this change makes all cases I tested work (tracepoint with default, default, ,-c, -F) This fixed specifying -c / -F with json event list eve