Re: [PATCH 9/9] pinctrl: at91: add missing of_node_put

2015-10-27 Thread Linus Walleij
On Sat, Oct 24, 2015 at 4:42 PM, Julia Lawall wrote: > for_each_child_of_node performs an of_node_get on each iteration, so > a break out of the loop requires an of_node_put. > > A simplified version of the semantic patch that fixes this problem is as > follows (http://coccinelle.lip6.fr): > > //

Re: [PATCH 9/9] pinctrl: at91: add missing of_node_put

2015-10-26 Thread Ludovic Desroches
On Sat, Oct 24, 2015 at 04:42:35PM +0200, Julia Lawall wrote: > for_each_child_of_node performs an of_node_get on each iteration, so > a break out of the loop requires an of_node_put. > > A simplified version of the semantic patch that fixes this problem is as > follows (http://coccinelle.lip6.fr)

[PATCH 9/9] pinctrl: at91: add missing of_node_put

2015-10-24 Thread Julia Lawall
for_each_child_of_node performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; @@ for_each_chi