Re: [PATCH AUTOSEL 4.18 032/136] arm64: fix infinite stacktrace

2018-09-21 Thread Sasha Levin
On Tue, Sep 18, 2018 at 12:00:51PM +0100, Will Deacon wrote: >On Tue, Sep 18, 2018 at 06:55:34AM -0400, Mikulas Patocka wrote: >> This patch is not correct, because the stacktrace is supposed to work >> around discontiguous interrupt stacks. >> >> You should replace 'frame->fp <= fp' with 'frame->f

Re: [PATCH AUTOSEL 4.18 032/136] arm64: fix infinite stacktrace

2018-09-18 Thread Will Deacon
On Tue, Sep 18, 2018 at 06:55:34AM -0400, Mikulas Patocka wrote: > This patch is not correct, because the stacktrace is supposed to work > around discontiguous interrupt stacks. > > You should replace 'frame->fp <= fp' with 'frame->fp == fp'. No, just drop the patch. It was already reverted upst

Re: [PATCH AUTOSEL 4.18 032/136] arm64: fix infinite stacktrace

2018-09-18 Thread Mikulas Patocka
This patch is not correct, because the stacktrace is supposed to work around discontiguous interrupt stacks. You should replace 'frame->fp <= fp' with 'frame->fp == fp'. Mikulas On Mon, 17 Sep 2018, Sasha Levin wrote: > From: Mikulas Patocka > > [ Upstream commit 7e7df71fd57ff2894d96abb008

[PATCH AUTOSEL 4.18 032/136] arm64: fix infinite stacktrace

2018-09-16 Thread Sasha Levin
From: Mikulas Patocka [ Upstream commit 7e7df71fd57ff2894d96abb0080922bf39460a79 ] I've got this infinite stacktrace when debugging another problem: [ 908.795225] INFO: rcu_preempt detected stalls on CPUs/tasks: [ 908.796176] 1-...!: (1 GPs behind) idle=952/1/4611686018427387904 softirq=1462