Re: [PATCH AUTOSEL 4.19 06/42] scripts/sphinx-pre-install: fix script for RHEL/CentOS

2019-08-03 Thread Alexander Kapshuk
On Sat, Aug 3, 2019 at 1:37 PM Mauro Carvalho Chehab wrote: > > Em Sat, 3 Aug 2019 13:31:30 +0300 > Alexander Kapshuk escreveu: > > > > - if (! $system_release =~ /Fedora/) { > > > + if (!($system_release =~ /Fedora/)) { > > > $map{"virtualenv"} = "python-virtualenv";

Re: [PATCH AUTOSEL 4.19 06/42] scripts/sphinx-pre-install: fix script for RHEL/CentOS

2019-08-03 Thread Mauro Carvalho Chehab
Em Sat, 3 Aug 2019 13:31:30 +0300 Alexander Kapshuk escreveu: > > - if (! $system_release =~ /Fedora/) { > > + if (!($system_release =~ /Fedora/)) { > > $map{"virtualenv"} = "python-virtualenv"; > > } > > The negated binding operator '!~' could be used here as

Re: [PATCH AUTOSEL 4.19 06/42] scripts/sphinx-pre-install: fix script for RHEL/CentOS

2019-08-03 Thread Alexander Kapshuk
On Sat, Aug 3, 2019 at 11:19 AM Sasha Levin wrote: > > From: Mauro Carvalho Chehab > > [ Upstream commit b308467c916aa7acc5069802ab76a9f657434701 ] > > There's a missing parenthesis at the script, with causes it to > fail to detect non-Fedora releases (e. g. RHEL/CentOS). > > Tested with Centos 7

[PATCH AUTOSEL 4.19 06/42] scripts/sphinx-pre-install: fix script for RHEL/CentOS

2019-08-02 Thread Sasha Levin
From: Mauro Carvalho Chehab [ Upstream commit b308467c916aa7acc5069802ab76a9f657434701 ] There's a missing parenthesis at the script, with causes it to fail to detect non-Fedora releases (e. g. RHEL/CentOS). Tested with Centos 7.6.1810. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sash