Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On Tue, Mar 13, 2018 at 08:44:49PM +0100, Jacek Anaszewski wrote: > On 03/13/2018 02:27 PM, Pavel Machek wrote: > > Hi! > > > At least 7b6af2c531 ("leds: core: Fix regression caused by commit > 2b83ff96f51d") is missing, causing visible regressions (LEDs not working > at >

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On Tue, Mar 13, 2018 at 08:44:49PM +0100, Jacek Anaszewski wrote: > On 03/13/2018 02:27 PM, Pavel Machek wrote: > > Hi! > > > At least 7b6af2c531 ("leds: core: Fix regression caused by commit > 2b83ff96f51d") is missing, causing visible regressions (LEDs not working > at >

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On 03/13/2018 02:27 PM, Pavel Machek wrote: > Hi! > At least 7b6af2c531 ("leds: core: Fix regression caused by commit 2b83ff96f51d") is missing, causing visible regressions (LEDs not working at all) on some OpenWrt devices. This was fixed in 4.4.121 by reverting the offending

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On 03/13/2018 02:27 PM, Pavel Machek wrote: > Hi! > At least 7b6af2c531 ("leds: core: Fix regression caused by commit 2b83ff96f51d") is missing, causing visible regressions (LEDs not working at all) on some OpenWrt devices. This was fixed in 4.4.121 by reverting the offending

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

Hi! > > > At least 7b6af2c531 ("leds: core: Fix regression caused by commit > > > 2b83ff96f51d") is missing, causing visible regressions (LEDs not working > > > at > > > all) on some OpenWrt devices. This was fixed in 4.4.121 by reverting the > > > offending commit, but if I followed the

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

Hi! > > > At least 7b6af2c531 ("leds: core: Fix regression caused by commit > > > 2b83ff96f51d") is missing, causing visible regressions (LEDs not working > > > at > > > all) on some OpenWrt devices. This was fixed in 4.4.121 by reverting the > > > offending commit, but if I followed the

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

MP`` > >>>>>> and > >>>>>>``CONFIG_PREEMPT.`` > >>>>>> > >>>>>> stable-kernel-rules.rst: > >>>>>> > >>>>>> Rules on what kind of patches are accepted, and which ones are not,

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

MP`` > >>>>>> and > >>>>>>``CONFIG_PREEMPT.`` > >>>>>> > >>>>>> stable-kernel-rules.rst: > >>>>>> > >>>>>> Rules on what kind of patches are accepted, and which ones are not,

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

Hi! > > At least 7b6af2c531 ("leds: core: Fix regression caused by commit > > 2b83ff96f51d") is missing, causing visible regressions (LEDs not working at > > all) on some OpenWrt devices. This was fixed in 4.4.121 by reverting the > > offending commit, but if I followed the discussion correctly,

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

Hi! > > At least 7b6af2c531 ("leds: core: Fix regression caused by commit > > 2b83ff96f51d") is missing, causing visible regressions (LEDs not working at > > all) on some OpenWrt devices. This was fixed in 4.4.121 by reverting the > > offending commit, but if I followed the discussion correctly,

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

`CONFIG_PREEMPT.`` >>>>>> >>>>>> stable-kernel-rules.rst: >>>>>> >>>>>> Rules on what kind of patches are accepted, and which ones are not, >>>>>> into the "-stable" tree: >>>>>>

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

`CONFIG_PREEMPT.`` >>>>>> >>>>>> stable-kernel-rules.rst: >>>>>> >>>>>> Rules on what kind of patches are accepted, and which ones are not, >>>>>> into the "-stable" tree: >>>>>>

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

which ones are not, >>>>> into the "-stable" tree: >>>>> >>>>> - It must be obviously correct and tested. >>>>> - It must fix a real bug that bothers people (not a, "This could be a >>>>> problem

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

which ones are not, >>>>> into the "-stable" tree: >>>>> >>>>> - It must be obviously correct and tested. >>>>> - It must fix a real bug that bothers people (not a, "This could be a >>>>> problem

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

orrect and tested. > >>> - It must fix a real bug that bothers people (not a, "This could be a > >>> problem..." type thing). > >> > >> So you're saying that this doesn't qualify as a bug? > >> > >>>> This is a backport of a

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

orrect and tested. > >>> - It must fix a real bug that bothers people (not a, "This could be a > >>> problem..." type thing). > >> > >> So you're saying that this doesn't qualify as a bug? > >> > >>>> This is a backport of a

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

>> >>> - It must be obviously correct and tested. >>> - It must fix a real bug that bothers people (not a, "This could be a >>> problem..." type thing). >> >> So you're saying that this doesn't qualify as a bug? >> >>>> This is

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

>> >>> - It must be obviously correct and tested. >>> - It must fix a real bug that bothers people (not a, "This could be a >>> problem..." type thing). >> >> So you're saying that this doesn't qualify as a bug? >> >>>> This is

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On Tue 2018-02-06 02:02:19, Sasha Levin wrote: > On Sun, Feb 04, 2018 at 06:17:36PM +0100, Pavel Machek wrote: > > > >> > > >> *** if brightness=0, led off > >> > > >> *** else apply brightness if next timer <--- timer is stop, and > >> > > >> will never apply new setting > >> > > >> ** otherwise

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On Tue 2018-02-06 02:02:19, Sasha Levin wrote: > On Sun, Feb 04, 2018 at 06:17:36PM +0100, Pavel Machek wrote: > > > >> > > >> *** if brightness=0, led off > >> > > >> *** else apply brightness if next timer <--- timer is stop, and > >> > > >> will never apply new setting > >> > > >> ** otherwise

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

> > So you're saying that this doesn't qualify as a bug? > >>> This is a backport of a patch that is already upstream. If it doesn't >>> belong in a stable tree, great, let us know that, saying why it is so. >> >> See jacek.anaszew...@gmail.com

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

> > So you're saying that this doesn't qualify as a bug? > >>> This is a backport of a patch that is already upstream. If it doesn't >>> belong in a stable tree, great, let us know that, saying why it is so. >> >> See jacek.anaszew...@gmail.com

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On Sun, Feb 04, 2018 at 06:17:36PM +0100, Pavel Machek wrote: > >> > > >> *** if brightness=0, led off >> > > >> *** else apply brightness if next timer <--- timer is stop, and will >> > > >> never apply new setting >> > > >> ** otherwise set led_set_brightness_nosleep >> > > >> >> > > >> To fix

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On Sun, Feb 04, 2018 at 06:17:36PM +0100, Pavel Machek wrote: > >> > > >> *** if brightness=0, led off >> > > >> *** else apply brightness if next timer <--- timer is stop, and will >> > > >> never apply new setting >> > > >> ** otherwise set led_set_brightness_nosleep >> > > >> >> > > >> To fix

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On Sun 2018-02-04 15:49:06, Sasha Levin wrote: > On Sun, Feb 04, 2018 at 10:05:31AM +0100, Pavel Machek wrote: > >On Sun 2018-02-04 00:30:36, Sasha Levin wrote: > >> On Sat, Feb 03, 2018 at 09:35:26PM +0100, Pavel Machek wrote: > >> >On Sat 2018-02-03 18:00:59, Sasha Levin wrote: > >> >> From:

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On Sun 2018-02-04 15:49:06, Sasha Levin wrote: > On Sun, Feb 04, 2018 at 10:05:31AM +0100, Pavel Machek wrote: > >On Sun 2018-02-04 00:30:36, Sasha Levin wrote: > >> On Sat, Feb 03, 2018 at 09:35:26PM +0100, Pavel Machek wrote: > >> >On Sat 2018-02-03 18:00:59, Sasha Levin wrote: > >> >> From:

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

> > > >> *** if brightness=0, led off > > > >> *** else apply brightness if next timer <--- timer is stop, and will > > > >> never apply new setting > > > >> ** otherwise set led_set_brightness_nosleep > > > >> > > > >> To fix that, when we delete the timer, we should clear LED_BLINK_SW. > > > >

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

> > > >> *** if brightness=0, led off > > > >> *** else apply brightness if next timer <--- timer is stop, and will > > > >> never apply new setting > > > >> ** otherwise set led_set_brightness_nosleep > > > >> > > > >> To fix that, when we delete the timer, we should clear LED_BLINK_SW. > > > >

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On Sun, Feb 04, 2018 at 10:05:31AM +0100, Pavel Machek wrote: >On Sun 2018-02-04 00:30:36, Sasha Levin wrote: >> On Sat, Feb 03, 2018 at 09:35:26PM +0100, Pavel Machek wrote: >> >On Sat 2018-02-03 18:00:59, Sasha Levin wrote: >> >> From: Matthieu CASTET >> >> >> >> [

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On Sun, Feb 04, 2018 at 10:05:31AM +0100, Pavel Machek wrote: >On Sun 2018-02-04 00:30:36, Sasha Levin wrote: >> On Sat, Feb 03, 2018 at 09:35:26PM +0100, Pavel Machek wrote: >> >On Sat 2018-02-03 18:00:59, Sasha Levin wrote: >> >> From: Matthieu CASTET >> >> >> >> [ Upstream commit

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On Sun, Feb 04, 2018 at 10:05:31AM +0100, Pavel Machek wrote: > On Sun 2018-02-04 00:30:36, Sasha Levin wrote: > > On Sat, Feb 03, 2018 at 09:35:26PM +0100, Pavel Machek wrote: > > >On Sat 2018-02-03 18:00:59, Sasha Levin wrote: > > >> From: Matthieu CASTET > > >> > >

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On Sun, Feb 04, 2018 at 10:05:31AM +0100, Pavel Machek wrote: > On Sun 2018-02-04 00:30:36, Sasha Levin wrote: > > On Sat, Feb 03, 2018 at 09:35:26PM +0100, Pavel Machek wrote: > > >On Sat 2018-02-03 18:00:59, Sasha Levin wrote: > > >> From: Matthieu CASTET > > >> > > >> [ Upstream commit

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On Sun 2018-02-04 00:30:36, Sasha Levin wrote: > On Sat, Feb 03, 2018 at 09:35:26PM +0100, Pavel Machek wrote: > >On Sat 2018-02-03 18:00:59, Sasha Levin wrote: > >> From: Matthieu CASTET > >> > >> [ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ] > >> > >>

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On Sun 2018-02-04 00:30:36, Sasha Levin wrote: > On Sat, Feb 03, 2018 at 09:35:26PM +0100, Pavel Machek wrote: > >On Sat 2018-02-03 18:00:59, Sasha Levin wrote: > >> From: Matthieu CASTET > >> > >> [ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ] > >> > >> With the current code, the

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On Sat, Feb 03, 2018 at 09:35:26PM +0100, Pavel Machek wrote: >On Sat 2018-02-03 18:00:59, Sasha Levin wrote: >> From: Matthieu CASTET >> >> [ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ] >> >> With the current code, the following sequence won't work : >>

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On Sat, Feb 03, 2018 at 09:35:26PM +0100, Pavel Machek wrote: >On Sat 2018-02-03 18:00:59, Sasha Levin wrote: >> From: Matthieu CASTET >> >> [ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ] >> >> With the current code, the following sequence won't work : >> echo timer > trigger >> >>

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On Sat 2018-02-03 18:00:59, Sasha Levin wrote: > From: Matthieu CASTET > > [ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ] > > With the current code, the following sequence won't work : > echo timer > trigger > > echo 0 > delay_off > * at this point we

Re: [PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

On Sat 2018-02-03 18:00:59, Sasha Levin wrote: > From: Matthieu CASTET > > [ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ] > > With the current code, the following sequence won't work : > echo timer > trigger > > echo 0 > delay_off > * at this point we call > **

[PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

From: Matthieu CASTET [ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ] With the current code, the following sequence won't work : echo timer > trigger echo 0 > delay_off * at this point we call ** led_delay_off_store ** led_blink_set *** stop timer **

[PATCH AUTOSEL for 4.14 065/110] led: core: Fix brightness setting when setting delay_off=0

From: Matthieu CASTET [ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ] With the current code, the following sequence won't work : echo timer > trigger echo 0 > delay_off * at this point we call ** led_delay_off_store ** led_blink_set *** stop timer ** led_blink_setup **