Re: [PATCH AUTOSEL for 4.9 002/219] spi/bcm63xx: make spi subsystem aware of message size limits

2018-03-06 Thread Mark Brown
On Tue, Mar 06, 2018 at 04:33:34PM +0100, Jonas Gorski wrote: > I would assume that this is true for most systems with a limited SPI > controller. I would hope that most board designers are sensible enough > to not add devices that won't work ;-) With things like firmware downloads the problem is

Re: [PATCH AUTOSEL for 4.9 002/219] spi/bcm63xx: make spi subsystem aware of message size limits

2018-03-06 Thread Jonas Gorski
On 6 March 2018 at 15:20, Mark Brown wrote: > On Tue, Mar 06, 2018 at 02:42:43PM +0100, Jonas Gorski wrote: >> On 5 March 2018 at 21:35, Mark Brown wrote: > >> > It's exposing more capability information but it's in the "how did this >> > ever work without the fix" range, and I'd worry that this

Re: [PATCH AUTOSEL for 4.9 002/219] spi/bcm63xx: make spi subsystem aware of message size limits

2018-03-06 Thread Mark Brown
On Tue, Mar 06, 2018 at 02:42:43PM +0100, Jonas Gorski wrote: > On 5 March 2018 at 21:35, Mark Brown wrote: > > It's exposing more capability information but it's in the "how did this > > ever work without the fix" range, and I'd worry that this might cause us > > to do something like start exerc

Re: [PATCH AUTOSEL for 4.9 002/219] spi/bcm63xx: make spi subsystem aware of message size limits

2018-03-06 Thread Jonas Gorski
On 5 March 2018 at 21:35, Mark Brown wrote: > On Mon, Mar 05, 2018 at 08:07:46PM +, Sasha Levin wrote: >> On Mon, Mar 05, 2018 at 10:23:10AM +, Mark Brown wrote: >> >On Sat, Mar 03, 2018 at 10:27:56PM +, Sasha Levin wrote: > >> >> The bcm63xx SPI controller does not allow manual contro

Re: [PATCH AUTOSEL for 4.9 002/219] spi/bcm63xx: make spi subsystem aware of message size limits

2018-03-05 Thread Mark Brown
On Mon, Mar 05, 2018 at 08:07:46PM +, Sasha Levin wrote: > On Mon, Mar 05, 2018 at 10:23:10AM +, Mark Brown wrote: > >On Sat, Mar 03, 2018 at 10:27:56PM +, Sasha Levin wrote: > >> The bcm63xx SPI controller does not allow manual control of the CS > >> lines and will toggle it automatic

Re: [PATCH AUTOSEL for 4.9 002/219] spi/bcm63xx: make spi subsystem aware of message size limits

2018-03-05 Thread Sasha Levin
On Mon, Mar 05, 2018 at 10:23:10AM +, Mark Brown wrote: >On Sat, Mar 03, 2018 at 10:27:56PM +, Sasha Levin wrote: >> From: Jonas Gorski >> >> [ Upstream commit 0135c03df914f0481c61f097c78d37cece84f330 ] > >Why are there so many more patches for v4.9 than for more recent >kernels? The v4.1

Re: [PATCH AUTOSEL for 4.9 002/219] spi/bcm63xx: make spi subsystem aware of message size limits

2018-03-05 Thread Mark Brown
On Sat, Mar 03, 2018 at 10:27:56PM +, Sasha Levin wrote: > From: Jonas Gorski > > [ Upstream commit 0135c03df914f0481c61f097c78d37cece84f330 ] Why are there so many more patches for v4.9 than for more recent kernels? > The bcm63xx SPI controller does not allow manual control of the CS > lin

[PATCH AUTOSEL for 4.9 002/219] spi/bcm63xx: make spi subsystem aware of message size limits

2018-03-03 Thread Sasha Levin
From: Jonas Gorski [ Upstream commit 0135c03df914f0481c61f097c78d37cece84f330 ] The bcm63xx SPI controller does not allow manual control of the CS lines and will toggle it automatically before and after sending data, so we are limited to messages that fit in the FIFO buffer. Since the CS lines a