Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 24 feb 2018, alle ore 13:05, Ming Lei ha > scritto: > > On Sat, Feb 24, 2018 at 08:54:31AM +0100, Paolo Valente wrote: >> >> >>> Il giorno 23 feb 2018, alle ore 17:17, Ming Lei ha >>> scritto: >>> >>> Hi Paolo, >>> >>> On Fri, Feb

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 24 feb 2018, alle ore 13:05, Ming Lei ha > scritto: > > On Sat, Feb 24, 2018 at 08:54:31AM +0100, Paolo Valente wrote: >> >> >>> Il giorno 23 feb 2018, alle ore 17:17, Ming Lei ha >>> scritto: >>> >>> Hi Paolo, >>> >>> On Fri, Feb 23, 2018 at 04:41:36PM +0100, Paolo Valente

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

On Sat, Feb 24, 2018 at 08:54:31AM +0100, Paolo Valente wrote: > > > > Il giorno 23 feb 2018, alle ore 17:17, Ming Lei ha > > scritto: > > > > Hi Paolo, > > > > On Fri, Feb 23, 2018 at 04:41:36PM +0100, Paolo Valente wrote: > >> > >> > >>> Il giorno 23 feb 2018, alle

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

On Sat, Feb 24, 2018 at 08:54:31AM +0100, Paolo Valente wrote: > > > > Il giorno 23 feb 2018, alle ore 17:17, Ming Lei ha > > scritto: > > > > Hi Paolo, > > > > On Fri, Feb 23, 2018 at 04:41:36PM +0100, Paolo Valente wrote: > >> > >> > >>> Il giorno 23 feb 2018, alle ore 16:07, Ming Lei

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 23 feb 2018, alle ore 17:17, Ming Lei ha > scritto: > > Hi Paolo, > > On Fri, Feb 23, 2018 at 04:41:36PM +0100, Paolo Valente wrote: >> >> >>> Il giorno 23 feb 2018, alle ore 16:07, Ming Lei ha >>> scritto: >>> >>> Hi Paolo, >>> >>>

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 23 feb 2018, alle ore 17:17, Ming Lei ha > scritto: > > Hi Paolo, > > On Fri, Feb 23, 2018 at 04:41:36PM +0100, Paolo Valente wrote: >> >> >>> Il giorno 23 feb 2018, alle ore 16:07, Ming Lei ha >>> scritto: >>> >>> Hi Paolo, >>> >>> On Wed, Feb 07, 2018 at 10:19:20PM +0100,

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

Hi Paolo, On Fri, Feb 23, 2018 at 04:41:36PM +0100, Paolo Valente wrote: > > > > Il giorno 23 feb 2018, alle ore 16:07, Ming Lei ha > > scritto: > > > > Hi Paolo, > > > > On Wed, Feb 07, 2018 at 10:19:20PM +0100, Paolo Valente wrote: > >> Commit 'a6a252e64914

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

Hi Paolo, On Fri, Feb 23, 2018 at 04:41:36PM +0100, Paolo Valente wrote: > > > > Il giorno 23 feb 2018, alle ore 16:07, Ming Lei ha > > scritto: > > > > Hi Paolo, > > > > On Wed, Feb 07, 2018 at 10:19:20PM +0100, Paolo Valente wrote: > >> Commit 'a6a252e64914 ("blk-mq-sched: decide how to

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 23 feb 2018, alle ore 16:07, Ming Lei ha > scritto: > > Hi Paolo, > > On Wed, Feb 07, 2018 at 10:19:20PM +0100, Paolo Valente wrote: >> Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via >> RQF_FLUSH_SEQ")' makes all non-flush re-prepared

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 23 feb 2018, alle ore 16:07, Ming Lei ha > scritto: > > Hi Paolo, > > On Wed, Feb 07, 2018 at 10:19:20PM +0100, Paolo Valente wrote: >> Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via >> RQF_FLUSH_SEQ")' makes all non-flush re-prepared requests for a device

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

Hi Paolo, On Wed, Feb 07, 2018 at 10:19:20PM +0100, Paolo Valente wrote: > Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via > RQF_FLUSH_SEQ")' makes all non-flush re-prepared requests for a device > be re-inserted into the active I/O scheduler for that device. As a No, this

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

Hi Paolo, On Wed, Feb 07, 2018 at 10:19:20PM +0100, Paolo Valente wrote: > Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via > RQF_FLUSH_SEQ")' makes all non-flush re-prepared requests for a device > be re-inserted into the active I/O scheduler for that device. As a No, this

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 10 feb 2018, alle ore 09:29, Oleksandr Natalenko > ha scritto: > > Hi. > > On pátek 9. února 2018 18:29:39 CET Mike Galbraith wrote: >> On Fri, 2018-02-09 at 14:21 +0100, Oleksandr Natalenko wrote: >>> In addition to this I think it should be worth

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 10 feb 2018, alle ore 09:29, Oleksandr Natalenko > ha scritto: > > Hi. > > On pátek 9. února 2018 18:29:39 CET Mike Galbraith wrote: >> On Fri, 2018-02-09 at 14:21 +0100, Oleksandr Natalenko wrote: >>> In addition to this I think it should be worth considering CC'ing Greg >>> to

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

Hi. On pátek 9. února 2018 18:29:39 CET Mike Galbraith wrote: > On Fri, 2018-02-09 at 14:21 +0100, Oleksandr Natalenko wrote: > > In addition to this I think it should be worth considering CC'ing Greg > > to pull this fix into 4.15 stable tree. > > This isn't one he can cherry-pick, some munging

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

Hi. On pátek 9. února 2018 18:29:39 CET Mike Galbraith wrote: > On Fri, 2018-02-09 at 14:21 +0100, Oleksandr Natalenko wrote: > > In addition to this I think it should be worth considering CC'ing Greg > > to pull this fix into 4.15 stable tree. > > This isn't one he can cherry-pick, some munging

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

On Fri, 2018-02-09 at 14:21 +0100, Oleksandr Natalenko wrote: > > In addition to this I think it should be worth considering CC'ing Greg > to pull this fix into 4.15 stable tree. This isn't one he can cherry-pick, some munging required, in which case he usually wants a properly tested backport.

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

On Fri, 2018-02-09 at 14:21 +0100, Oleksandr Natalenko wrote: > > In addition to this I think it should be worth considering CC'ing Greg > to pull this fix into 4.15 stable tree. This isn't one he can cherry-pick, some munging required, in which case he usually wants a properly tested backport.

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

On 2/9/18 6:21 AM, Oleksandr Natalenko wrote: > Hi. > > 08.02.2018 08:16, Paolo Valente wrote: >>> Il giorno 07 feb 2018, alle ore 23:18, Jens Axboe ha >>> scritto: >>> >>> On 2/7/18 2:19 PM, Paolo Valente wrote: Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

On 2/9/18 6:21 AM, Oleksandr Natalenko wrote: > Hi. > > 08.02.2018 08:16, Paolo Valente wrote: >>> Il giorno 07 feb 2018, alle ore 23:18, Jens Axboe ha >>> scritto: >>> >>> On 2/7/18 2:19 PM, Paolo Valente wrote: Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

Hi. 08.02.2018 08:16, Paolo Valente wrote: Il giorno 07 feb 2018, alle ore 23:18, Jens Axboe ha scritto: On 2/7/18 2:19 PM, Paolo Valente wrote: Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via RQF_FLUSH_SEQ")' makes all non-flush re-prepared requests

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

Hi. 08.02.2018 08:16, Paolo Valente wrote: Il giorno 07 feb 2018, alle ore 23:18, Jens Axboe ha scritto: On 2/7/18 2:19 PM, Paolo Valente wrote: Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via RQF_FLUSH_SEQ")' makes all non-flush re-prepared requests for a device be

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 07 feb 2018, alle ore 23:18, Jens Axboe ha > scritto: > > On 2/7/18 2:19 PM, Paolo Valente wrote: >> Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via >> RQF_FLUSH_SEQ")' makes all non-flush re-prepared requests for a device >> be re-inserted

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

> Il giorno 07 feb 2018, alle ore 23:18, Jens Axboe ha > scritto: > > On 2/7/18 2:19 PM, Paolo Valente wrote: >> Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via >> RQF_FLUSH_SEQ")' makes all non-flush re-prepared requests for a device >> be re-inserted into the active

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

On 2/7/18 2:19 PM, Paolo Valente wrote: > Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via > RQF_FLUSH_SEQ")' makes all non-flush re-prepared requests for a device > be re-inserted into the active I/O scheduler for that device. As a > consequence, I/O schedulers may get the

Re: [PATCH BUGFIX V3] block, bfq: add requeue-request hook

On 2/7/18 2:19 PM, Paolo Valente wrote: > Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via > RQF_FLUSH_SEQ")' makes all non-flush re-prepared requests for a device > be re-inserted into the active I/O scheduler for that device. As a > consequence, I/O schedulers may get the

[PATCH BUGFIX V3] block, bfq: add requeue-request hook

Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via RQF_FLUSH_SEQ")' makes all non-flush re-prepared requests for a device be re-inserted into the active I/O scheduler for that device. As a consequence, I/O schedulers may get the same request inserted again, even several times,

[PATCH BUGFIX V3] block, bfq: add requeue-request hook

Commit 'a6a252e64914 ("blk-mq-sched: decide how to handle flush rq via RQF_FLUSH_SEQ")' makes all non-flush re-prepared requests for a device be re-inserted into the active I/O scheduler for that device. As a consequence, I/O schedulers may get the same request inserted again, even several times,