On Fri, 2013-02-22 at 05:57 -0300, Mauro Carvalho Chehab wrote:
> Em Fri, 22 Feb 2013 05:50:21 -0300
> Mauro Carvalho Chehab escreveu:
>
> > Em Fri, 22 Feb 2013 08:45:11 +0800
> > Huang Ying escreveu:
> >
> > > On Thu, 2013-02-21 at 09:04 -0300, Mauro Carvalho Chehab wrote:
> > > > Em Thu, 21
On Fri, 2013-02-22 at 05:57 -0300, Mauro Carvalho Chehab wrote:
Em Fri, 22 Feb 2013 05:50:21 -0300
Mauro Carvalho Chehab mche...@redhat.com escreveu:
Em Fri, 22 Feb 2013 08:45:11 +0800
Huang Ying ying.hu...@intel.com escreveu:
On Thu, 2013-02-21 at 09:04 -0300, Mauro Carvalho Chehab
Em Fri, 22 Feb 2013 08:45:11 +0800
Huang Ying escreveu:
> On Thu, 2013-02-21 at 09:04 -0300, Mauro Carvalho Chehab wrote:
> > Em Thu, 21 Feb 2013 09:26:07 +0800
> > Huang Ying escreveu:
> >
> > There is also an advantage on taking this approach: this patch can have just
> > the ghes changes,
Em Fri, 22 Feb 2013 05:50:21 -0300
Mauro Carvalho Chehab escreveu:
> Em Fri, 22 Feb 2013 08:45:11 +0800
> Huang Ying escreveu:
>
> > On Thu, 2013-02-21 at 09:04 -0300, Mauro Carvalho Chehab wrote:
> > > Em Thu, 21 Feb 2013 09:26:07 +0800
> > > Huang Ying escreveu:
> > >
>
> > > There is
Em Fri, 22 Feb 2013 05:50:21 -0300
Mauro Carvalho Chehab mche...@redhat.com escreveu:
Em Fri, 22 Feb 2013 08:45:11 +0800
Huang Ying ying.hu...@intel.com escreveu:
On Thu, 2013-02-21 at 09:04 -0300, Mauro Carvalho Chehab wrote:
Em Thu, 21 Feb 2013 09:26:07 +0800
Huang Ying
Em Fri, 22 Feb 2013 08:45:11 +0800
Huang Ying ying.hu...@intel.com escreveu:
On Thu, 2013-02-21 at 09:04 -0300, Mauro Carvalho Chehab wrote:
Em Thu, 21 Feb 2013 09:26:07 +0800
Huang Ying ying.hu...@intel.com escreveu:
There is also an advantage on taking this approach: this patch can
Documentation/SubmittingPatches,
> session 2, item 1:
>
> 2) #ifdefs are ugly
>
> Code cluttered with ifdefs is difficult to read and maintain. Don't do
> it. Instead, put your ifdefs in a header, and conditionally define
> 'static inline' functi
are used in the code.
Let the compiler optimize away the "no-op" case.
Simple example, of poor code:
dev = alloc_etherdev (sizeof(struct funky_private));
if (!dev)
return -ENODEV;
#ifdef CONFIG_NET_FUNKI
, as CONFIG_EDAC_GHES is not
defined yet. So, the patch becomes is simpler and easier to review.
If I would do it otherwise, I would need to fold patch 5 to avoid breaking
git bisect.
Regards,
Mauro
Patch with the changes enclosed.
-
[PATCH EDACv2 03/13] ghes: add the needed hooks for EDAC error
with the changes enclosed.
-
[PATCH EDACv2 03/13] ghes: add the needed hooks for EDAC error report
In order to allow reporting errors via EDAC, add hooks for:
1) register an EDAC driver;
2) unregister an EDAC driver;
3) report errors via EDAC.
As the EDAC driver will need to access
Sorry for late!
On Fri, 2013-02-15 at 10:44 -0200, Mauro Carvalho Chehab wrote:
> In order to allow reporting errors via EDAC, add hooks for:
>
> 1) register an EDAC driver;
> 2) unregister an EDAC driver;
> 3) report errors via EDAC.
>
> As the EDAC driver will need to access the ghes
Sorry for late!
On Fri, 2013-02-15 at 10:44 -0200, Mauro Carvalho Chehab wrote:
In order to allow reporting errors via EDAC, add hooks for:
1) register an EDAC driver;
2) unregister an EDAC driver;
3) report errors via EDAC.
As the EDAC driver will need to access the ghes structure, adds
In order to allow reporting errors via EDAC, add hooks for:
1) register an EDAC driver;
2) unregister an EDAC driver;
3) report errors via EDAC.
As the EDAC driver will need to access the ghes structure, adds it
as one of the parameters for ghes_do_proc.
Signed-off-by: Mauro Carvalho Chehab
In order to allow reporting errors via EDAC, add hooks for:
1) register an EDAC driver;
2) unregister an EDAC driver;
3) report errors via EDAC.
As the EDAC driver will need to access the ghes structure, adds it
as one of the parameters for ghes_do_proc.
Signed-off-by: Mauro Carvalho Chehab
14 matches
Mail list logo
