Re: [PATCH LINUX v3 05/10] tty: xuartps: Improve startup function

2015-12-05 Thread Sören Brinkmann
On Sat, 2015-12-05 at 12:21PM -0500, Peter Hurley wrote: > On 11/21/2015 09:59 PM, Soren Brinkmann wrote: > > The startup function is supposed to initialize the UART for receiving. > > Hence, don't enable the TX part. Also, protect HW accesses with the port > > lock. > > Reviewed-by: Peter Hurley

Re: [PATCH LINUX v3 05/10] tty: xuartps: Improve startup function

2015-12-05 Thread Peter Hurley
On 11/21/2015 09:59 PM, Soren Brinkmann wrote: > The startup function is supposed to initialize the UART for receiving. > Hence, don't enable the TX part. Also, protect HW accesses with the port > lock. Reviewed-by: Peter Hurley NB: the request_irq() should be _after_ h/w programming, otherwise

[PATCH LINUX v3 05/10] tty: xuartps: Improve startup function

2015-11-21 Thread Soren Brinkmann
The startup function is supposed to initialize the UART for receiving. Hence, don't enable the TX part. Also, protect HW accesses with the port lock. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 20 1 file changed, 12 insertions(+), 8 deletions(-)