Re: [PATCH LINUX v3 09/10] tty: xuartps: Only handle RX IRQs when RX is enabled

2015-12-05 Thread Sören Brinkmann
On Sat, 2015-12-05 at 12:43PM -0500, Peter Hurley wrote: > On 11/21/2015 09:59 PM, Soren Brinkmann wrote: > > Ignore RX-related interrupts if RX is not enabled. > > This doesn't look like a safe approach; fast-forward a couple of years and > some is trying to add some feature but can't figure out

Re: [PATCH LINUX v3 09/10] tty: xuartps: Only handle RX IRQs when RX is enabled

2015-12-05 Thread Peter Hurley
On 11/21/2015 09:59 PM, Soren Brinkmann wrote: > Ignore RX-related interrupts if RX is not enabled. This doesn't look like a safe approach; fast-forward a couple of years and some is trying to add some feature but can't figure out why no data is arriving... What is this trying to solve? Regards,

[PATCH LINUX v3 09/10] tty: xuartps: Only handle RX IRQs when RX is enabled

2015-11-21 Thread Soren Brinkmann
Ignore RX-related interrupts if RX is not enabled. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index db9e23eaf300