Re: [PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify.

2017-07-20 Thread Jiri Kosina
On Sat, 8 Jul 2017, Christos Gkekas wrote: > Variable mode in method wacom_show_remote_mode() is defined as u8, thus > statement (mode >= 0) is always true and should be removed, simplifying > the logic. > > Signed-off-by: Christos Gkekas Applied to for-4.14/wacom,

Re: [PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify.

2017-07-20 Thread Jiri Kosina
On Sat, 8 Jul 2017, Christos Gkekas wrote: > Variable mode in method wacom_show_remote_mode() is defined as u8, thus > statement (mode >= 0) is always true and should be removed, simplifying > the logic. > > Signed-off-by: Christos Gkekas Applied to for-4.14/wacom, thanks. -- Jiri Kosina

Re: [PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify.

2017-07-12 Thread Benjamin Tissoires
On Jul 08 2017 or thereabouts, Christos Gkekas wrote: > Variable mode in method wacom_show_remote_mode() is defined as u8, thus > statement (mode >= 0) is always true and should be removed, simplifying > the logic. > > Signed-off-by: Christos Gkekas > --- Reviewed-by:

Re: [PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify.

2017-07-12 Thread Benjamin Tissoires
On Jul 08 2017 or thereabouts, Christos Gkekas wrote: > Variable mode in method wacom_show_remote_mode() is defined as u8, thus > statement (mode >= 0) is always true and should be removed, simplifying > the logic. > > Signed-off-by: Christos Gkekas > --- Reviewed-by: Benjamin Tissoires >

[PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify.

2017-07-08 Thread Christos Gkekas
Variable mode in method wacom_show_remote_mode() is defined as u8, thus statement (mode >= 0) is always true and should be removed, simplifying the logic. Signed-off-by: Christos Gkekas --- drivers/hid/wacom_sys.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-)

[PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify.

2017-07-08 Thread Christos Gkekas
Variable mode in method wacom_show_remote_mode() is defined as u8, thus statement (mode >= 0) is always true and should be removed, simplifying the logic. Signed-off-by: Christos Gkekas --- drivers/hid/wacom_sys.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git