On Fri 25-01-08 19:34:07, Nick Piggin wrote:
> > > But let's see... there must be a memory ordering problem here in existing
> > > code anyway, because I don't see any barriers. Between b_assoc_buffers
> > > and b_state (via buffer_dirty); fsync_buffers_list vs
> > > mark_buffer_dirty_inode,
On Fri 25-01-08 19:34:07, Nick Piggin wrote:
But let's see... there must be a memory ordering problem here in existing
code anyway, because I don't see any barriers. Between b_assoc_buffers
and b_state (via buffer_dirty); fsync_buffers_list vs
mark_buffer_dirty_inode, right?
I'm
On Fri 25-01-08 19:34:07, Nick Piggin wrote:
> On Thursday 24 January 2008 02:48, Jan Kara wrote:
>
> > In the current version, we readd buffer to
> > private_list if it is found dirty in the second while loop of
> > fsync_buffers() and that should be enough.
>
> Sure, I think there is
On Thursday 24 January 2008 02:48, Jan Kara wrote:
> On Thu 24-01-08 02:05:16, Nick Piggin wrote:
> > On Thursday 24 January 2008 00:30, Jan Kara wrote:
> > > On Wed 23-01-08 12:00:02, Nick Piggin wrote:
> > > > On Wednesday 23 January 2008 04:10, Jan Kara wrote:
> > > > > Hi,
> > > > >
> > > >
On Thursday 24 January 2008 02:48, Jan Kara wrote:
On Thu 24-01-08 02:05:16, Nick Piggin wrote:
On Thursday 24 January 2008 00:30, Jan Kara wrote:
On Wed 23-01-08 12:00:02, Nick Piggin wrote:
On Wednesday 23 January 2008 04:10, Jan Kara wrote:
Hi,
as I got no answer
On Fri 25-01-08 19:34:07, Nick Piggin wrote:
On Thursday 24 January 2008 02:48, Jan Kara wrote:
snip
In the current version, we readd buffer to
private_list if it is found dirty in the second while loop of
fsync_buffers() and that should be enough.
Sure, I think there is still a
On Thu 24-01-08 02:05:16, Nick Piggin wrote:
> On Thursday 24 January 2008 00:30, Jan Kara wrote:
> > On Wed 23-01-08 12:00:02, Nick Piggin wrote:
> > > On Wednesday 23 January 2008 04:10, Jan Kara wrote:
> > > > Hi,
> > > >
> > > > as I got no answer for a week, I'm resending this fix for
On Thursday 24 January 2008 00:30, Jan Kara wrote:
> On Wed 23-01-08 12:00:02, Nick Piggin wrote:
> > On Wednesday 23 January 2008 04:10, Jan Kara wrote:
> > > Hi,
> > >
> > > as I got no answer for a week, I'm resending this fix for races in
> > > private_list handling. Andrew, do you like
On Wed 23-01-08 12:00:02, Nick Piggin wrote:
> On Wednesday 23 January 2008 04:10, Jan Kara wrote:
> > Hi,
> >
> > as I got no answer for a week, I'm resending this fix for races in
> > private_list handling. Andrew, do you like them more than the previous
> > version?
>
> FWIW, I reviewed
On Wed 23-01-08 12:00:02, Nick Piggin wrote:
On Wednesday 23 January 2008 04:10, Jan Kara wrote:
Hi,
as I got no answer for a week, I'm resending this fix for races in
private_list handling. Andrew, do you like them more than the previous
version?
FWIW, I reviewed this, and it
On Thursday 24 January 2008 00:30, Jan Kara wrote:
On Wed 23-01-08 12:00:02, Nick Piggin wrote:
On Wednesday 23 January 2008 04:10, Jan Kara wrote:
Hi,
as I got no answer for a week, I'm resending this fix for races in
private_list handling. Andrew, do you like them more than
On Thu 24-01-08 02:05:16, Nick Piggin wrote:
On Thursday 24 January 2008 00:30, Jan Kara wrote:
On Wed 23-01-08 12:00:02, Nick Piggin wrote:
On Wednesday 23 January 2008 04:10, Jan Kara wrote:
Hi,
as I got no answer for a week, I'm resending this fix for races in
On Wednesday 23 January 2008 04:10, Jan Kara wrote:
> Hi,
>
> as I got no answer for a week, I'm resending this fix for races in
> private_list handling. Andrew, do you like them more than the previous
> version?
FWIW, I reviewed this, and it looks OK although I think some comments
would be
Hi,
as I got no answer for a week, I'm resending this fix for races in
private_list handling. Andrew, do you like them more than the previous
version?
Honza
--
Jan Kara <[EMAIL PROTECTED]>
SUSE Labs, CR
---
There are
Hi,
as I got no answer for a week, I'm resending this fix for races in
private_list handling. Andrew, do you like them more than the previous
version?
Honza
--
Jan Kara [EMAIL PROTECTED]
SUSE Labs, CR
---
There are two
On Wednesday 23 January 2008 04:10, Jan Kara wrote:
Hi,
as I got no answer for a week, I'm resending this fix for races in
private_list handling. Andrew, do you like them more than the previous
version?
FWIW, I reviewed this, and it looks OK although I think some comments
would be in
16 matches
Mail list logo