Re: [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-03-04 Thread Kent Yoder
On Thu, Feb 28, 2013 at 4:06 AM, Jean Delvare wrote: > From: Shubhrajyoti Datta > > Convert the struct i2c_msg initialization to C99 format. This makes > maintaining and editing the code simpler. Also helps once other fields > like transferred are added in future. > > Thanks to Julia Lawall for a

RE: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-03-04 Thread Peter.Huewe
>> Yes, no problem. >> I'll create a patch without it - >> I'll make it this way that you can apply the conversion patch first >> and then the change. >Thanks! >Kent The new version of my patch was just sent - please apply this one first. Thanks, Peter -

Re: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-02-28 Thread Peter Hüwe
> > I'd suggest not to. Mixing actual changes with cleanups is generally > > discouraged. > > Yes, please don't do this. Also because it makes it really > confusing for me to figure out whether something has been applied or > not and if I have the right people on the sign off. > > Peter, can

Re: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-02-28 Thread Kent Yoder
On Thu, Feb 28, 2013 at 4:32 PM, Jean Delvare wrote: > On Thu, 28 Feb 2013 23:12:51 +0100, Peter Hüwe wrote: >> thanks for resending. > > You're welcome. > >> Am Donnerstag, 28. Februar 2013, 11:06:11 schrieb Jean Delvare: >> > From: Shubhrajyoti Datta >> > >> > Convert the struct i2c_msg initial

Re: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-02-28 Thread Jean Delvare
On Thu, 28 Feb 2013 23:12:51 +0100, Peter Hüwe wrote: > thanks for resending. You're welcome. > Am Donnerstag, 28. Februar 2013, 11:06:11 schrieb Jean Delvare: > > From: Shubhrajyoti Datta > > > > Convert the struct i2c_msg initialization to C99 format. This makes > > maintaining and editing th

Re: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-02-28 Thread Peter Hüwe
Hi, thanks for resending. Am Donnerstag, 28. Februar 2013, 11:06:11 schrieb Jean Delvare: > From: Shubhrajyoti Datta > > Convert the struct i2c_msg initialization to C99 format. This makes > maintaining and editing the code simpler. Also helps once other fields > like transferred are added in

[PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-02-28 Thread Jean Delvare
From: Shubhrajyoti Datta Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like transferred are added in future. Thanks to Julia Lawall for automating the conversion. Signed-off-by: Shubhrajyoti D Acked-by