Re: [PATCH RESEND] fs: Move @f_count to different cacheline with @f_mode

2020-09-08 Thread Jan Kara
On Wed 24-06-20 16:32:28, Shaokun Zhang wrote: > get_file_rcu_many, which is called by __fget_files, has used > atomic_try_cmpxchg now and it can reduce the access number of the global > variable to improve the performance of atomic instruction compared with > atomic_cmpxchg. > > __fget_files doe

Re: [PATCH RESEND] fs: Move @f_count to different cacheline with @f_mode

2020-08-27 Thread Shaokun Zhang
Hi Aleksa, 在 2020/8/26 16:24, Aleksa Sarai 写道: > On 2020-08-26, Shaokun Zhang wrote: >> 在 2020/8/22 0:02, Will Deacon 写道: >>> - This thing is tagged with __randomize_layout, so it doesn't help anybody >>> using that crazy plugin >> >> This patch isolated the @f_count with @f_mode absolutely

Re: [PATCH RESEND] fs: Move @f_count to different cacheline with @f_mode

2020-08-26 Thread Aleksa Sarai
On 2020-08-26, Shaokun Zhang wrote: > 在 2020/8/22 0:02, Will Deacon 写道: > > - This thing is tagged with __randomize_layout, so it doesn't help anybody > > using that crazy plugin > > This patch isolated the @f_count with @f_mode absolutely and we don't care the > base address of the structu

Re: [PATCH RESEND] fs: Move @f_count to different cacheline with @f_mode

2020-08-26 Thread Shaokun Zhang
Hi Will, 在 2020/8/22 0:02, Will Deacon 写道: > On Wed, Jun 24, 2020 at 04:32:28PM +0800, Shaokun Zhang wrote: >> get_file_rcu_many, which is called by __fget_files, has used >> atomic_try_cmpxchg now and it can reduce the access number of the global >> variable to improve the performance of atomic i

Re: [PATCH RESEND] fs: Move @f_count to different cacheline with @f_mode

2020-08-21 Thread Will Deacon
On Wed, Jun 24, 2020 at 04:32:28PM +0800, Shaokun Zhang wrote: > get_file_rcu_many, which is called by __fget_files, has used > atomic_try_cmpxchg now and it can reduce the access number of the global > variable to improve the performance of atomic instruction compared with > atomic_cmpxchg. > >

[PATCH RESEND] fs: Move @f_count to different cacheline with @f_mode

2020-06-24 Thread Shaokun Zhang
get_file_rcu_many, which is called by __fget_files, has used atomic_try_cmpxchg now and it can reduce the access number of the global variable to improve the performance of atomic instruction compared with atomic_cmpxchg. __fget_files does check the @f_mode with mask variable and will do some ato