Re: [PATCH RESEND] ocfs2: use retval instead of status for checking error

2015-05-03 13:13 GMT+09:00 Andrew Morton : > On Sun, 3 May 2015 12:02:39 +0900 DaeSeok Youn wrote: > >> 2015-04-24 10:45 GMT+09:00 Daeseok Youn : >> > The use of 'status' in __ocfs2_add_entry() can return wrong >> > value. Some functions' return value in __ocfs2_add_entry(), >> > i.e ocfs2_journal

Re: [PATCH RESEND] ocfs2: use retval instead of status for checking error

On Sun, 3 May 2015 12:02:39 +0900 DaeSeok Youn wrote: > 2015-04-24 10:45 GMT+09:00 Daeseok Youn : > > The use of 'status' in __ocfs2_add_entry() can return wrong > > value. Some functions' return value in __ocfs2_add_entry(), > > i.e ocfs2_journal_access_di() is saved to 'status'. > > But 'status

Re: [PATCH RESEND] ocfs2: use retval instead of status for checking error

2015-04-24 10:45 GMT+09:00 Daeseok Youn : > The use of 'status' in __ocfs2_add_entry() can return wrong > value. Some functions' return value in __ocfs2_add_entry(), > i.e ocfs2_journal_access_di() is saved to 'status'. > But 'status' is not used in 'bail' label for returning result > of __ocfs2_ad

Re: [PATCH RESEND] ocfs2: use retval instead of status for checking error

Hi, Andrew. 2015-04-24 10:45 GMT+09:00 Daeseok Youn : > The use of 'status' in __ocfs2_add_entry() can return wrong > value. Some functions' return value in __ocfs2_add_entry(), > i.e ocfs2_journal_access_di() is saved to 'status'. > But 'status' is not used in 'bail' label for returning result >

[PATCH RESEND] ocfs2: use retval instead of status for checking error

The use of 'status' in __ocfs2_add_entry() can return wrong value. Some functions' return value in __ocfs2_add_entry(), i.e ocfs2_journal_access_di() is saved to 'status'. But 'status' is not used in 'bail' label for returning result of __ocfs2_add_entry(). So use retval instead of status. Review